Fix FT roles not being assigned sometimes#101
Merged
Conversation
In DefaultLogParsingRulesSelector, we go through the fight names to see which content we need to check prog for. We do this by comparing fight names to role names, since the role names all have the fight name in them. However, fight names can sometimes be empty, in which case they'll always match any string. This had the unfortunate effect of always marking affected logs as DRS fights, since that gets checked before FT. This commit fixes the issue by skipping fights with empty/whitespace names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DefaultLogParsingRulesSelector, we go through the fight names to see which content we need to check prog for. We do this by comparing fight names to role names, since the role names all have the fight name in them. However, fight names can sometimes be empty, in which case they'll always match any string. This had the unfortunate effect of always marking affected logs as DRS fights, since that gets checked before FT.
This commit fixes the issue by skipping fights with empty/whitespace names.
Also added more logging to make it easier to identify these issues in the future.