Release v0.5#276
Merged
Merged
Conversation
Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
* Add PPA work-level methods & unit tests * Added method to extract page meta from page_id
Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
Resolves warning about unresolved link in readme
…xcerpts Add method to find overlapping excerpts
* Add poem cluster ids when compiling metadata Preliminary revisions to poem metadata * Add unit tests for save poem metadata with poem cluster ids * Add new config option to sample config * Convert config to dataclasses, simple defaults, relative paths * Use revised config logic for ref-corpus & compile dataset * Refactor common repeated resolve path logic Assisted-by: Claude:sonnet-4-6 [ClaudeCode] * Clean up resolve logic; test relative dir when ref dir inferred * Refactor tests to use new config Assisted-by: Claude:sonnet-4-6 [ClaudeCode] * Simplify config fixtures for tests * Move validation logic to config; use config object for test fixture * Use the same passim defaults in CLI args and run_python method * Fix metadata path init+validation so url works as expected * Remove old code, clean up comments and docstrings * Apply suggestion from @laurejt Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com> * Update sample_config.yml to match revised config file structure * Correct the compile dataset setting name in sample config file * Update test config and notebooks checked in CI for new configuration * Shift more validation logic to config classes * Test loading metadata from file & calculating poem lengths * Add missing config options to "maximal" config test * Make ppa corpus path relative to the top-level base dir * Apply suggestions from code review Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com> * Don't resolve compiled dataset dir relative to base dir; & other cleanup - clarify passim defaults in comments - improve configuration validation & tests - add docstring to config validation method Revised based on @laurejt review feedback --------- Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 84.93% 82.18% -2.75%
==========================================
Files 37 23 -14
Lines 4607 2156 -2451
==========================================
- Hits 3913 1772 -2141
+ Misses 694 384 -310 🚀 New features to boost your workflow:
|
laurejt
requested changes
May 12, 2026
laurejt
left a comment
laurejt
left a comment
Contributor
There was a problem hiding this comment.
This looks good overall, but some additions need to be made to the changelog.
Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
Co-authored-by: Laure Thompson <602628+laurejt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue(s): resolves #275
Questions
Reviewer Checklist