Skip to content

Add v2.6 model interface#831

Merged
bejaeger merged 28 commits into
mainfrom
ben/add-2.6-model-interface
Mar 24, 2026
Merged

Add v2.6 model interface#831
bejaeger merged 28 commits into
mainfrom
ben/add-2.6-model-interface

Conversation

@bejaeger
Copy link
Copy Markdown
Collaborator

@bejaeger bejaeger commented Mar 20, 2026

  • Doesn't make 2.6 the default choice just yet.
  • To be merged once models are uploaded.

@bejaeger bejaeger requested a review from a team as a code owner March 20, 2026 10:24
@bejaeger bejaeger requested review from priorjulien and removed request for a team March 20, 2026 10:24
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@bejaeger bejaeger removed the request for review from priorjulien March 20, 2026 10:24
@bejaeger bejaeger marked this pull request as draft March 20, 2026 10:24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the v2.6 model, including new interfaces, constants, and configurations. The changes are mostly straightforward additions to support the new version. I've identified a couple of areas for improvement:

  • There's an opportunity to refactor duplicated code in classifier.py and regressor.py where default options for different model versions are created. Using a dictionary lookup would make this code more maintainable.
  • In inference_config.py, the latest model configuration should point to the new v2.6 preprocessor configs for consistency and to prevent future bugs.

Overall, the changes are well-structured and the addition of tests for the new version is great.

Comment thread src/tabpfn/classifier.py
Comment thread src/tabpfn/inference_config.py Outdated
Comment thread src/tabpfn/regressor.py
@bejaeger bejaeger requested a review from priorphil March 20, 2026 10:38
Comment thread src/tabpfn/inference_config.py Outdated
@bejaeger bejaeger marked this pull request as ready for review March 24, 2026 09:05
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@bejaeger bejaeger added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit bbb9122 Mar 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants