chore(parser): pin shared PromQL parser revision - #385
Merged
Conversation
zzylol
force-pushed
the
chore/pin-promql-parser-d7606436
branch
from
September 10, 2026 21:23
6585744 to
6d60232
Compare
zzylol
force-pushed
the
chore/pin-promql-parser-d7606436
branch
from
September 10, 2026 21:33
24aab23 to
6d60232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shared parser fork now includes the reviewed v0.10 parser fixes and recognizes
distinct_over_timeandentropy_over_time. Planner must use the same immutable revision as backend parsing.What
Pin
asap-frontend-promqlto ProjectASAP/promql-parser commitd7606436bde05efe19c5398fe2122faa49062f7dand refresh the lockfile.How
The frontend keeps ownership of PromQL lowering. The parser dependency only expands accepted syntax; functions receive acceleration semantics only through an explicit lowerer mapping.
Before this PR
Planner resolved the older fork revision
c51beafb.After this PR
Planner resolves v0.10 from
d7606436.distinct_over_timeandentropy_over_timeparse but remain exact-only because the lowerer rejects them.topk_over_timeremains outside the parser contract.Verification
cargo check -p asap-frontend-promqldistinct_over_timeandentropy_over_timeparse and then fail lowering withUnsupportedFunction.cargo tree -p asap-frontend-promqlresolves onlyd7606436.cargo fmt -p asap-frontend-promql -- --checkgit diff --checkLimitations
This PR does not add lowering, planning, or runtime support for the newly parsed MetricsQL reducers.