Skip to content

chore(parser): pin shared PromQL parser revision - #385

Merged
zzylol merged 3 commits into
mainfrom
chore/pin-promql-parser-d7606436
Sep 10, 2026
Merged

chore(parser): pin shared PromQL parser revision#385
zzylol merged 3 commits into
mainfrom
chore/pin-promql-parser-d7606436

Conversation

@milindsrivastava1997

@milindsrivastava1997 milindsrivastava1997 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Why

The shared parser fork now includes the reviewed v0.10 parser fixes and recognizes distinct_over_time and entropy_over_time. Planner must use the same immutable revision as backend parsing.

What

Pin asap-frontend-promql to ProjectASAP/promql-parser commit d7606436bde05efe19c5398fe2122faa49062f7d and refresh the lockfile.

How

The frontend keeps ownership of PromQL lowering. The parser dependency only expands accepted syntax; functions receive acceleration semantics only through an explicit lowerer mapping.

Before this PR

Planner resolved the older fork revision c51beafb.

After this PR

Planner resolves v0.10 from d7606436. distinct_over_time and entropy_over_time parse but remain exact-only because the lowerer rejects them. topk_over_time remains outside the parser contract.

Verification

  • cargo check -p asap-frontend-promql
  • Boundary test proves distinct_over_time and entropy_over_time parse and then fail lowering with UnsupportedFunction.
  • cargo tree -p asap-frontend-promql resolves only d7606436.
  • cargo fmt -p asap-frontend-promql -- --check
  • git diff --check

Limitations

This PR does not add lowering, planning, or runtime support for the newly parsed MetricsQL reducers.

@zzylol
zzylol force-pushed the chore/pin-promql-parser-d7606436 branch from 6585744 to 6d60232 Compare September 10, 2026 21:23
@zzylol zzylol changed the title chore: pin promql-parser fork chore(parser): pin shared PromQL parser revision Sep 10, 2026
@zzylol
zzylol force-pushed the chore/pin-promql-parser-d7606436 branch from 24aab23 to 6d60232 Compare September 10, 2026 21:33
@zzylol
zzylol merged commit 8905040 into main Sep 10, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants