Skip to content

fix(precompute): route SetAggregator and DeltaSetAggregator, preserve deltas - #668

Merged
milindsrivastava1997 merged 6 commits into
mainfrom
477-precompute-factory-mis-builds-deltasetaggregator-and-setaggregator-as-sum
Sep 2, 2026
Merged

fix(precompute): route SetAggregator and DeltaSetAggregator, preserve deltas#668
milindsrivastava1997 merged 6 commits into
mainfrom
477-precompute-factory-mis-builds-deltasetaggregator-and-setaggregator-as-sum

Conversation

@milindsrivastava1997

Copy link
Copy Markdown
Contributor

Summary

Closes #477

  • Route SetAggregator and DeltaSetAggregator to keyed updaters instead of silently falling back to Sum.
  • Preserve DeltaSetAggregator added/removed key differences across windows.
  • Drop ForwardToStore samples for DeltaSetAggregator because append-only late corrections cannot preserve stateful deltas.
  • Fix first-batch, multi-window watermark handling so on-time samples are not treated as evicted.
  • Reject unknown subpopulation aggregation subtypes instead of silently defaulting.

Verification

  • cargo test --workspace -- --test-threads=1
  • Pre-commit formatting, check, clippy, and test hooks pass.

@milindsrivastava1997 milindsrivastava1997 changed the title fix(precompute): route and preserve DeltaSetAggregator key deltas fix(precompute): route SetAggregator and DeltaSetAggregator, preserve deltas Sep 2, 2026
@milindsrivastava1997
milindsrivastava1997 marked this pull request as ready for review September 2, 2026 13:34
@milindsrivastava1997
milindsrivastava1997 merged commit e7d2f55 into main Sep 2, 2026
10 checks passed
@milindsrivastava1997
milindsrivastava1997 deleted the 477-precompute-factory-mis-builds-deltasetaggregator-and-setaggregator-as-sum branch September 2, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Precompute factory mis-builds DeltaSetAggregator and SetAggregator as Sum

1 participant