Skip to content

fix(planner): model count-min sketch heap costs - #691

Merged
milindsrivastava1997 merged 3 commits into
mainfrom
651-countminsketchwithheap-still-costs-at-the-flat-stub-cms-heap-wrapper-exists-but-isnt-wired-up
Sep 3, 2026
Merged

fix(planner): model count-min sketch heap costs#691
milindsrivastava1997 merged 3 commits into
mainfrom
651-countminsketchwithheap-still-costs-at-the-flat-stub-cms-heap-wrapper-exists-but-isnt-wired-up

Conversation

@milindsrivastava1997

Copy link
Copy Markdown
Contributor

Closes #651

Summary

  • Wire CountMinSketchWithHeap into atomic cost resolution using the regular-path/top-k benchmark reference.
  • Scale CPU costs linearly from heap size 32 and model runtime memory analytically.
  • Warn and drop candidates when reference data is missing or malformed, preserving EXACT fallback.
  • Add per-candidate cost measurements and regression coverage.
  • Update the optimizer implementation-plan status.

Verification

  • cargo clippy -p asap_planner --all-targets -- -D warnings
  • cargo test --workspace -- --test-threads=1

@milindsrivastava1997
milindsrivastava1997 marked this pull request as ready for review September 3, 2026 15:25
@milindsrivastava1997
milindsrivastava1997 merged commit 8721634 into main Sep 3, 2026
16 checks passed
@milindsrivastava1997
milindsrivastava1997 deleted the 651-countminsketchwithheap-still-costs-at-the-flat-stub-cms-heap-wrapper-exists-but-isnt-wired-up branch September 3, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CountMinSketchWithHeap still costs at the flat stub — cms-heap wrapper exists but isn't wired up

1 participant