Skip to content

🐛 resourcePackSha1 が v1.0.6 の値でない問題を修正#30

Open
haiiro2gou wants to merge 1 commit intomasterfrom
fix/resource-hash
Open

🐛 resourcePackSha1 が v1.0.6 の値でない問題を修正#30
haiiro2gou wants to merge 1 commit intomasterfrom
fix/resource-hash

Conversation

@haiiro2gou
Copy link
Member

Copilot AI review requested due to automatic review settings March 1, 2026 09:53
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tsb c69d492 Commit Preview URL

Branch Preview URL
Mar 01 2026, 09:54 AM

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes ProjectTSB/TheSkyBlessing#2240 by correcting the resourcePackSha1 value for stable version v1.0.6, ensuring the published SHA1 matches the intended resource pack release.

Changes:

  • Update stableVersion.resourcePackSha1 to the correct SHA1 for v1.0.6.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 23 to +25
resourcePackUrl: "https://github.com/ProjectTSB/TheSkyBlessing/releases/download/v1.0.6/resources.zip",
multiplayResourcePackUrl: "https://github.com/ProjectTSB/TSB-ResourcePack/releases/download/v1.0.6/resources.zip",
resourcePackSha1: "b1eb7500e5f03e4f1def6fb43b05a017b70050ff",
resourcePackSha1: "0360d3e3b5a1e8b8e9f3e15b2fdc2caaa601a403",
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resourcePackSha1 is ambiguous because StableVersionInfo has both resourcePackUrl and multiplayResourcePackUrl, but the UI displays this SHA1 under the multiplayer resource pack section. Consider renaming it (e.g. multiplayResourcePackSha1) and/or adding a separate SHA1 for resourcePackUrl to reduce the chance of future mismatches.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.0.6/resources.zipのsha1が合いません

2 participants