Make attestation and verification synchronous - #76
Merged
bzp99 merged 9 commits intoSep 12, 2026
Merged
Conversation
bzp99
changed the title
bzp99
force-pushed
the
feat/dva-api-attestation
branch
from
September 12, 2026 13:26
90c15ed to
6aad598
Compare
bzp99
force-pushed
the
feat/dva-api-attestation
branch
from
September 12, 2026 13:29
6aad598 to
61e5127
Compare
bzp99
merged commit Sep 12, 2026
61e5127
into
Prometheus-X-association:yassine-refactor
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the previous async RabbitMQ-backed attestation flow with a synchronous POST
/attestationthat returns the AoV JWS inline and a POST/attestation/verifythat delegates todva-vc-manager./attestationvalidatesvlaId(UUID parse), fetches the VLA fromvla-manager-api, batches evaluation againstdva-processing, and on success asksdva-vc-managerto issue the JWS; on failure returns 200 withevaluationPassing=falseandjws=null/attestation/verifyforwards the JWS todva-vc-managerdataProvideris used as the VCsubject(falls back toattesterID)AoVSyncRoutesTest(4 unit tests) covers pass/fail issue and verified true/false verify paths using aMockEngine-backedHttpClient;ktor-client-mockdependency addedAoVRoutesTest.ktremoved (superseded byAoVSyncRoutesTest.kt)Depends on: #72 (ACA-Py removal), #73 (dva-vc-manager), #74 (vla-manager-api), #75 (slim dva-api-processing)
@bzp99