feat: add connection pooling support via USE_POOL toggle #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add USE_POOL env var to switch between direct and pooled DB connections - Support pool-specific vars: DB_POOL_PORT, DB_POOL_NAME, DB_APPUSER, DB_APPUSER_PASSWORD - Add DB_SSLMODE support (defaults to "prefer") - Validate required env vars based on connection mode - Add tests for direct mode, pooled mode, and missing var validation - Document connection pooling setup in deployment docs Closes #143 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Documents how to create a database user with limited permissions for use with pooled connections, following least-privilege principle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
USE_POOLenvironment variable to switch between direct and pooled database connectionsDB_POOL_PORT,DB_POOL_NAME,DB_APPUSER,DB_APPUSER_PASSWORDDB_SSLMODEsupport (defaults to"prefer")Closes #143
Test plan
test_get_connection_url_direct_mode- verifies direct mode uses standard DB varstest_get_connection_url_pooled_mode- verifies pooled mode uses pool-specific varstest_get_connection_url_missing_direct_vars- verifies ValueError on missing direct varstest_get_connection_url_missing_pool_vars- verifies ValueError on missing pool vars🤖 Generated with Claude Code