[codex] science-grade GRRT validation contracts - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6ec9f3d28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| push: | ||
| tags: | ||
| - "v*" |
There was a problem hiding this comment.
Keep release artifacts behind manual dispatch
GitHub documents the push.tags filter as running the workflow when matching tags are pushed, so this new v* trigger turns every version-tag push into an artifact-delivery run that builds and uploads Python/native wheels even when no release was explicitly requested. The repository policy says .github/workflows/ is CI-only and must not publish releases without an explicit request, so this should be limited to workflow_dispatch until release work is intentionally requested.
Useful? React with 👍 / 👎.
| b_con = np.asarray(sample.b_con, dtype=float) | ||
| if spin_a is not None and sample.valid: | ||
| try: | ||
| g_cov = kerr_metric_covariant(float(sample.r), float(sample.theta), float(spin_a)) |
There was a problem hiding this comment.
Catch singular metric divisions in field fallback
For snapshots whose radial grid includes the horizon (r = r_+) or samples that land exactly there, kerr_metric_covariant divides by Delta = 0 before this helper can fall back to the Euclidean norm, and ZeroDivisionError is not caught by the new exception list. That makes coefficient-brick precompute and polarized transfer abort on a single horizon cell even though this path is meant to have a compatibility fallback; guard the horizon or include this exception before using the metric result.
Useful? React with 👍 / 👎.
Summary
This PR redirects the simulator toward a validated GRRT research-platform contract while preserving the existing Python reference and accelerator layering.
Changes include:
educational_proxyversusvalidatedunpolarized transfer modeValidation
python -m pytest -q tests/test_synchrotron_polarized_transfer.py tests/test_radiative_transfer.py tests/test_native_kernel_assets.py tests/test_kerr.pypython -m compileall blackhole_simpython -m pytest -qcargo fmt --check --manifest-path native/core/Cargo.tomlcargo test --manifest-path native/core/Cargo.tomlpython -m blackhole_sim.accelerator_cli doctor --json --fail-on-emulationpython -m blackhole_sim.benchmark_cli --json --nr 3 --ntheta 3 --nphi 4 --points 7 --iterations 1python -m blackhole_sim.accelerated_cli --width 32 --height 18 --max-steps 64 --output out\science_redirection_smoke.npzquick_validate.pyfor all seven installed science skillsNot Claimed