Skip to content

fix(ci): restore check workflow compliance#210

Merged
skulidropek merged 3 commits intomainfrom
fix/restore-check-workflow
Apr 6, 2026
Merged

fix(ci): restore check workflow compliance#210
skulidropek merged 3 commits intomainfrom
fix/restore-check-workflow

Conversation

@skulidropek
Copy link
Copy Markdown
Member

Summary

  • extract controller health probe and parsing into a dedicated module to satisfy app lint constraints
  • replace manual JSON parsing in controller health handling with Schema and ParseResult decoding
  • migrate lib auth snapshot tests away from node:fs to @effect/platform/FileSystem

Verification

  • pnpm --filter ./packages/app typecheck
  • pnpm --filter ./packages/app lint:effect
  • pnpm --filter ./packages/app exec eslint src/docker-git/controller.ts src/docker-git/controller-health.ts --format stylish
  • pnpm --filter ./packages/app exec vibecode-linter src/docker-git/controller.ts
  • pnpm --filter ./packages/app exec vitest run tests/docker-git/controller.test.ts
  • pnpm --filter ./packages/lib lint:effect
  • pnpm --filter ./packages/lib test

Mathematical Guarantees

Invariants

  • parseHealthRevision returns null for invalid, non-object, or blank revision payloads
  • controller bootstrap reuses a reachable controller only when the discovered revision matches the local revision
  • auth snapshot tests still exercise the same symlink and file-copy behavior without violating filesystem import policy

Postconditions

  • app effect-lint no longer fails on try/catch, unknown, or the explicit undefined call path in controller bootstrap
  • lib effect-lint no longer fails on node:fs imports in the touched tests

@skulidropek skulidropek merged commit 7585edd into main Apr 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant