Skip to content

can_decode v0.7#70

Merged
LelsersLasers merged 15 commits into
masterfrom
millan/can_decode_v0.7.0
May 27, 2026
Merged

can_decode v0.7#70
LelsersLasers merged 15 commits into
masterfrom
millan/can_decode_v0.7.0

Conversation

@LelsersLasers
Copy link
Copy Markdown
Member

  • Update to use latest version of can_decode
  • Also bumps can_dbc version
  • And a few patch versions

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the app to the newer can_decode (v0.7.0) / can-dbc (v9.0.0) APIs by migrating signal-value handling to the new physical/enum_label representation and adjusting CAN ID helpers accordingly.

Changes:

  • Bump can_decode to 0.7.0 and can-dbc to 9.0.0 (plus small patch bumps).
  • Replace DecodedSignalValue::{Numeric, Enum} matching with signal.value.physical and signal.value.enum_label across viewers/plots/parsers.
  • Rename util::msg_id helpers to util::can and add a helper to convert can_dbc::NumericValue to f64.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/util.rs Rename msg_id helper module to can; add NumericValue -> f64 conversion helper.
src/ui/viewer_table.rs Update signal display logic to use enum_label + physical.
src/ui/viewer_list.rs Update signal display logic to use enum_label + physical.
src/ui/send.rs Update CAN ID helper paths; adapt signal min/max handling to can_dbc::NumericValue.
src/ui/scope.rs Plot signal.value.physical directly.
src/ui/jitter.rs Update CAN ID helper paths.
src/ui/gg_plot.rs Use sig.value.physical for joystick axes.
src/ui/dynamics.rs Use sig.value.physical for IMU signals / steering angle.
src/ui/dbc_msg_picker.rs Update CAN ID helper paths.
src/ui/battery.rs Switch to physical for telemetry; simplify charging telemetry init with Default.
src/daq_log_parse/table.rs Write physical values to CSV table cells.
src/daq_log_parse/parse.rs Update CAN ID mask references to util::can.
src/can/thread.rs Update CAN ID helper paths and masks for send/decode.
src/can/driver.rs Update standard ID mask reference.
Cargo.toml Dependency bumps (can_decode, can-dbc, env_logger, rand).
Cargo.lock Lockfile updates for bumped dependencies and transitive changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ui/battery.rs Outdated
Comment thread src/ui/dynamics.rs Outdated
@LelsersLasers LelsersLasers requested a review from irvingywang May 9, 2026 02:39
@LelsersLasers LelsersLasers marked this pull request as ready for review May 9, 2026 02:49
@LelsersLasers LelsersLasers changed the title can_decode v0.7.0 can_decode v0.7 May 10, 2026
@LelsersLasers
Copy link
Copy Markdown
Member Author

wait to merge until PurdueElectricRacing/can_decode#29 goes in and then update to v0.7.1

@LelsersLasers LelsersLasers requested review from irvingywang and removed request for irvingywang May 27, 2026 21:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.

Comment thread Cargo.toml Outdated
Comment thread src/daq_log_parse/table.rs Outdated
Comment thread src/daq_log_parse/table.rs Outdated
Comment thread src/ui/viewer_table.rs
Comment thread src/ui/viewer_list.rs
@LelsersLasers LelsersLasers marked this pull request as draft May 27, 2026 21:39
@LelsersLasers LelsersLasers marked this pull request as ready for review May 27, 2026 21:46
@LelsersLasers LelsersLasers merged commit 204bbd7 into master May 27, 2026
1 check passed
@LelsersLasers LelsersLasers deleted the millan/can_decode_v0.7.0 branch May 27, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants