can_decode v0.7#70
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the app to the newer can_decode (v0.7.0) / can-dbc (v9.0.0) APIs by migrating signal-value handling to the new physical/enum_label representation and adjusting CAN ID helpers accordingly.
Changes:
- Bump
can_decodeto0.7.0andcan-dbcto9.0.0(plus small patch bumps). - Replace
DecodedSignalValue::{Numeric, Enum}matching withsignal.value.physicalandsignal.value.enum_labelacross viewers/plots/parsers. - Rename
util::msg_idhelpers toutil::canand add a helper to convertcan_dbc::NumericValuetof64.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util.rs | Rename msg_id helper module to can; add NumericValue -> f64 conversion helper. |
| src/ui/viewer_table.rs | Update signal display logic to use enum_label + physical. |
| src/ui/viewer_list.rs | Update signal display logic to use enum_label + physical. |
| src/ui/send.rs | Update CAN ID helper paths; adapt signal min/max handling to can_dbc::NumericValue. |
| src/ui/scope.rs | Plot signal.value.physical directly. |
| src/ui/jitter.rs | Update CAN ID helper paths. |
| src/ui/gg_plot.rs | Use sig.value.physical for joystick axes. |
| src/ui/dynamics.rs | Use sig.value.physical for IMU signals / steering angle. |
| src/ui/dbc_msg_picker.rs | Update CAN ID helper paths. |
| src/ui/battery.rs | Switch to physical for telemetry; simplify charging telemetry init with Default. |
| src/daq_log_parse/table.rs | Write physical values to CSV table cells. |
| src/daq_log_parse/parse.rs | Update CAN ID mask references to util::can. |
| src/can/thread.rs | Update CAN ID helper paths and masks for send/decode. |
| src/can/driver.rs | Update standard ID mask reference. |
| Cargo.toml | Dependency bumps (can_decode, can-dbc, env_logger, rand). |
| Cargo.lock | Lockfile updates for bumped dependencies and transitive changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
wait to merge until PurdueElectricRacing/can_decode#29 goes in and then update to v0.7.1 |
4eababa to
5b554b5
Compare
irvingywang
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can_decodecan_dbcversion