Inherit domain and authorization from superclass in Purple::Client - #25
Closed
kalashnikovisme wants to merge 2 commits into
Closed
Inherit domain and authorization from superclass in Purple::Client#25kalashnikovisme wants to merge 2 commits into
kalashnikovisme wants to merge 2 commits into
Conversation
kalashnikovisme
deleted the
codex/add-tests-for-domain-and-authorization-inheritance
branch
February 18, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
domainandauthorizationwhen not explicitly set on a subclass.Description
Purple::Client.domainreturn@domain || inherited_domainso subclasses inherit the domain when unset and add the private helperinherited_domainthat callssuperclass.domainif available.Purple::Client.authorizationreturn@authorization || inherited_authorizationso subclasses inherit authorization when unset and add the private helperinherited_authorizationthat callssuperclass.authorizationif available.spec/purple/client_inheritance_spec.rbthat verify inherited domain, inherited authorization, and the ability to override both in a subclass.Testing
spec/purple/client_inheritance_spec.rb(not executed in this environment).bundle exec rspec spec/purple/client_inheritance_spec.rb spec/purple/client_spec.rbbut the test run failed withbundler: command not found: rspecin the current environment.bundle installto install test dependencies but it failed due to network access to rubygems.org returning HTTP 403 Forbidden, preventing the tests from being executed here.Codex Task