fix(react): ensure event callbacks are updated on changes#250
Open
jamsinclair wants to merge 2 commits into
Open
fix(react): ensure event callbacks are updated on changes#250jamsinclair wants to merge 2 commits into
jamsinclair wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: b53a41b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jamsinclair is attempting to deploy a commit to the Purus Projects Team on Vercel. A member of the Team first needs to authorize it. |
jamsinclair
commented
Sep 15, 2025
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| // Update refs with latest options callbacks |
Author
There was a problem hiding this comment.
I think this useEffect retriggers on every re-render unless the consumer passes a stable options object reference to the useDraggable hook.
I don't think this will cause any performance concerns. If for some odd reason it does, the consumer can always wrap their object in useMemo or alternative solutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249
Problem
The hook does not correctly update the event callbacks passed through in the options. This results in stale references when the callbacks are invoked.
Solution
Update to keep track of the callbacks in refs and call these in the callbacks registered to the core
draggableinstance.Update the callback refs to ensure they remain up-to-date in the existing
useEffectthat has a dependency onoptionsQuestion: Will this also need to be fixed in v3?