MAINT: 1.0.x: handle mixed dtype cofficients correctly across inverse transforms#455
Merged
rgommers merged 1 commit intoPyWavelets:1.0.xfrom Feb 11, 2019
Merged
Conversation
use _check_dtype on the coarsest level approximation coeffs output array dtype is upcast if any detail coefficients have higher precision than the approximation coefficients. fix: make dtype upcast in idwt respect complex dtypes add a dtype upcast to idwtn to match the behavior of idwt test inverse SWT functions with mixed dtype coefficients test idwt and idwtn with mixed complex dtypes as well test mixed precision with wavedec/waverec as well idwtn: only compare dtypes if both coeffs are not None
Member
|
All green, merging. Thanks @grlee77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #450 to the 1.0.x branch. There were no conflicts when cherry-picking the commits, so this should be good to go once CI passes.