fix bug in iswtn for data of arbitrary shape when using user-specified axes#462
Merged
rgommers merged 2 commits intoPyWavelets:masterfrom Feb 18, 2019
Merged
fix bug in iswtn for data of arbitrary shape when using user-specified axes#462rgommers merged 2 commits intoPyWavelets:masterfrom
rgommers merged 2 commits intoPyWavelets:masterfrom
Conversation
Contributor
Author
|
i would like to also include this one in the next bug fix release if anyone can do a quick review |
Member
|
LGTM, merged. Thanks @grlee77 |
Member
|
that was a sloppy bug, makes me wonder if we should do odd shape testing in other functions |
Contributor
Author
I think it is already reasonably covered for wavedecn/waverecn. See for example: pywt/pywt/tests/test_multilevel.py Lines 641 to 645 in 2e3a224 and some other tests use odd size and/or a different size per axis. |
Contributor
Author
|
thanks for the quick review! |
grlee77
added a commit
that referenced
this pull request
Feb 18, 2019
Backport gh-462 (iswtn axis fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #460
The issue was a variable that should have only contained the shape of the transformed axes and not all axes. This was missed by the current tests because these used the same size on each axis of the transformed array so it didn't matter if the shape from the wrong axis was selected.
A new test case with various permutations of shapes and non-transformed axis was added. Specifically the test case tests the following shape, axes permutations: