user-friendly error messages about multilevel DWT format#471
Merged
grlee77 merged 5 commits intoPyWavelets:masterfrom Jul 25, 2019
Merged
user-friendly error messages about multilevel DWT format#471grlee77 merged 5 commits intoPyWavelets:masterfrom
grlee77 merged 5 commits intoPyWavelets:masterfrom
Conversation
grlee77
changed the title
This case can never be reached due to the new ValueError check above
Member
|
looks like a good idea. CI failures are real |
Contributor
Author
|
Thanks. I needed |
rgommers
reviewed
Feb 28, 2019
Member
|
LGTM module my one minor comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces more informative error messages in the case the coefficients from the wrong multilevel DWT type are used as input to a multilevel reconstruction. This has resulted in user confusion in due to the output of
pywt.array_to_coeffsandpywt.unravel_coeffsdefaulting to compatibility withwavedecn: see #470 and #357This was previously done for 1D in #358, but this PR attempts to do thisconsistently across
waverec,waverec2andwaverecn.In addition to the more informative error messages, I updated the docstring examples to explicitly specify
output_formatso that it is harder for users to overlook it.