Repository navigation
Admit Artifacts "1" so CompatHelper stops proposing it (0.8.8) - #74
Merged
Merged
Conversation
General registers a pre-1.6 copy of the Artifacts stdlib (1.3.0). Against a "1.11" entry CompatHelper reads it as a newer release and opens "bump compat for Artifacts to 1" on every run; its TOML rewrite also drops the comment on the ParamIO floor. `julia = "1.11"` already fixes which Artifacts loads, so "1" admits nothing more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 28, 2026
Contributor
|
📚 Docs preview: https://qatlashub.github.io/DataVault.jl/previews/PR74/ (updates on each push to this PR) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the 15 identical CompatHelper PRs #59–#73.
Why they appeared.
Artifactsis a stdlib, but General also registers a pre-1.6 copy (1.3.0). AgainstArtifacts = "1.11", CompatHelper reads 1.3.0 as a newer release and proposes"1.11, 1". Its TOML rewrite also deletes the comment on the ParamIO floor, so those PRs should not be merged.Why they piled up. CompatHelper's duplicate check only looks at PRs by
github-actions[bot], while the org workflow opens them withBOT_PAT. That is fixed separately inQAtlasHub/.github.This change.
Artifacts = "1". Becausejulia = "1.11", the Artifacts that can load is unchanged. Resolve and load were checked in a throwaway env.🤖 Generated with Claude Code