Repository navigation
Shard through TestShards.jl, and retire this repo's use of julia-ci.yml - #30
Merged
Merged
Conversation
…ci.yml TestShards is in General, so the sharding lives in a package now. This repository was on the org's `julia-ci.yml` at `shards: 1` — a third hand-written copy of the same vertical, being deleted once its three callers have moved. runtests.jl globs `test_*.jl` under test/ and includes each one, so a new file or a whole new directory is picked up by being on disk rather than by being added to the `dirs` list that used to sit here and could disagree with the tree. Nine units, the same nine files as before. `dirs`, `FIG_BASE` and `PATHS` go with it. Nothing in test/ referenced FIG_BASE or PATHS, `dirs` was only the loop's own input, and `mkpath.(values(PATHS))` was a no-op over an empty Dict — the rewrite orphans all three rather than merely leaving them unused. `test/paramio/fixtures/` is TOML data with no `test_` prefix, so it is not picked up. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
📚 Docs preview: https://codes.sota-shimozono.com/ParamIO.jl/previews/PR30/ (updates on each push to this PR) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestShards is in General, so the sharding lives in a package now.
This repository was on the org's
julia-ci.ymlatshards: 1— a third hand-written copy of the same vertical (a plan job, a coverage merge, a timing recorder), being deleted once its three callers have moved.DataVault.jl#36is the other one.What changes
runtests.jlglobstest_*.jlundertest/and includes each one. A new file, or a whole new directory, is picked up by being on disk rather than by being added to thedirslist that used to sit here and could disagree with the tree. Nine units, the same nine files as before.dirs,FIG_BASEandPATHSgo with it: nothing intest/referencedFIG_BASEorPATHS,dirswas only the loop's own input, andmkpath.(values(PATHS))was a no-op over an emptyDict. The rewrite orphans all three rather than merely leaving them unused.test/paramio/fixtures/is TOML data with notest_prefix, so it is not picked up.On the Codecov secret
Named rather than inherited. Whether it arrives is open: measured on
lab-sotashimozono/ITensorAD.jl#20, a secret did not survive the call into this same reusable — present in the caller's own job, empty inside the called workflow, with the secret named rather than inherited, so the form is not what does it. That caller is in a different organisation; this repository is not, andDataVault.jl#36is the probe that settles which boundary it is.If
collectwarns that no token reached it here, this repo needs the caller-side upload job (QAtlasHub/TestShards.jl/actions/upload-coverage) as well. See QAtlasHub/TestShards.jl#48.Notes
shards: 4for nine units. The diagnosis printed on every run names the knee for this suite.All shards passed.Refs QAtlasHub/TestShards.jl#13.
🤖 Generated with Claude Code