fix: complete i18n polish and channel batch selection behavior#4071
Open
yesbhautik wants to merge 9 commits intoQuantumNous:mainfrom
Open
fix: complete i18n polish and channel batch selection behavior#4071yesbhautik wants to merge 9 commits intoQuantumNous:mainfrom
yesbhautik wants to merge 9 commits intoQuantumNous:mainfrom
Conversation
Allow auth pages to render background effects without bottom clipping near the footer. Update footer copy with multilingual linked New API and QuantumNous branding text for consistent localization.
…trings
- Convert 55 hardcoded Chinese UI strings to t() calls across 17 components
(TwoFAVerification, DashboardSetting, SystemSetting, LanguageSelector,
MarkdownRenderer, ThinkingContent, DebugPanel, MessageContent, etc.)
- Add curated English translations for all newly wrapped keys
- Fill missing translation entries for all locales (zh-TW, fr, ru, ja, vi)
to reach 100% coverage across all 6 non-primary languages
- Replace same-as-source Chinese values in non-Chinese locale files with
proper localized text
- Fix French plural _one forms missing {{count}} placeholder
- Improve i18n fallback chain: non-Chinese locales now fall back through
English before Chinese; returnEmptyString=false prevents blank renders
Translate hardcoded user-facing strings across auth, channels, settings, and helper paths, and add missing English locale entries for newly used keys. Add a global i18n safeguard that falls back to English when non-Chinese locales still resolve to Chinese text to prevent mixed-language UI.
Localize remaining backend and frontend user-facing strings, wire native language/Semi locale mappings, and align translation resources across all supported locales. Normalize API-fed toast messages and tighten fallback guards so Japanese and other non-Chinese locales no longer leak mixed CN/EN text.
Keep the i18n sweep focused by dropping incidental bun lock updates and local dev ignore entries that were not required for localization behavior.
Exclude local Air and docker compose dev config files so personal environment artifacts do not appear as untracked changes.
Ensure static Semi modal confirms and Popconfirm instances inherit translated OK/Cancel labels so non-Chinese locales no longer show mixed Chinese button text.
Unify channel row selection into controlled key-based state so tag groups, leaf channels, and batch APIs stay consistent. Restore universal keyboard behavior by making Cmd/Ctrl+A toggle select-all/deselect-all and keeping Shift range selection anchored to the user's click flow.
Contributor
|
Important Review skippedToo many files! This PR contains 245 files, which is 95 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (245)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge upstream main into the contribution branch to clear PR conflict status. Resolve locale and settings conflicts by preserving both i18n additions and the latest quota display settings UI behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd/Ctrl+Atoggle,Shiftrange,Cmd/Ctrlmulti-select).Test plan
bunx eslint src/hooks/channels/useChannelsData.jsx src/components/table/channels/ChannelsTable.jsx src/components/table/channels/ChannelsColumnDefs.jsxbun run buildCmd/Ctrl+Aselect-all + deselect-all toggle, andShift+clickrange behavior from middle to top/bottom.