Conversation
replace_blank dropped every space in a run, so a doubled gap turned 12 and 34 into 1234.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace_blankdrops every space in a run. Chinese text normalization uses that helper, so版本 12 34comes back as版本1234. A single space between ASCII characters is already kept. A doubled space now collapses to that same one space, and a space next to a Chinese character is still removed.Test plan
python -m unittest test_frontend_utils.pyfails on the current helper (版本1234, anda bbecomesab) and passes after the change版本 12 34stays版本12 34,你 astays你a, anda bstaysa b