4-in-1 map verification request - #72
Merged
Merged
Conversation
Member
|
sorry I forgot about this pr, next time ping me on discord if I don't respond within a week. before reviewing tho, I would like to suggest that you add a script to every one of your maps that disables impact marks and enables them after the match is over. during the few days the mod jam server was live people would join and crash on your map. |
catornot
self-requested a review
March 22, 2026 08:54
Contributor
Author
|
I'll have a look into doing that tomorrow, though it may take a little bit of time as I haven't yet learned how to use scripts for this. |
Contributor
Author
|
Finally got around to making the script to auto-disable impact marks. Updating this PR to use the new versions of the mods. |
catornot
approved these changes
Apr 14, 2026
catornot
left a comment
Member
There was a problem hiding this comment.
Hash is good
and no malicious code
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<MOD_NAME> v<MOD_VERSION>
skrubslayer.mp_sanctuary v 0.0.4,
skrubslayer.mp_fieldbattle v 0.0.3,
skrubslayer.mp_structure v 0.0.2,
skrubslayer.mp_towers v 0.0.2
Did I read the whole README file and understood all of its content?
YES
Did I update verified-mods.json with my new mod's information?
YES
Has a previous version of my mod been previously verified?
mp_sanctuary and mp_fieldbattle have, at #51 and #71
Mod description
4 pretty simple MRVN maps, done in one request to save time as I had all of them ready to update or get verified at once (let me know if seperate requests would be better in the future).
Sanctuary had a small update to remove an unused texture called skybox that would overwrite the skybox in my other map when they are both loaded.
Fieldbattle had an update to hopefully fix a crash when you select to spawn as titan, and renamed it's grass texture as it would also get overwritten when loaded with other mods that had a texture called grass
Structure and towers are older maps I had made a little while ago, and have just gotten around to verifying. Structure is unchanged from the old version, and towers has had some visual updates.
Mod webpage link
https://thunderstore.io/c/northstar/p/skrubslayer69/mp_fieldbattle/
https://thunderstore.io/c/northstar/p/skrubslayer69/mp_towers/
https://thunderstore.io/c/northstar/p/skrubslayer69/mp_sanctuary/
https://thunderstore.io/c/northstar/p/skrubslayer69/mp_structure/