[MRG] Fix S3 file download failing with 403 SignatureDoesNotMatch#14
Open
chiku-samugari wants to merge 1 commit intoRCOSDP:masterfrom
Open
[MRG] Fix S3 file download failing with 403 SignatureDoesNotMatch#14chiku-samugari wants to merge 1 commit intoRCOSDP:masterfrom
chiku-samugari wants to merge 1 commit intoRCOSDP:masterfrom
Conversation
Added safe redirect handling for S3 in streaming methods to avoid forwarding API-specific headers that break presigned URL signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added safe redirect handling for S3 in streaming methods to avoid forwarding specific headers that break presigned URL signatures.
Background
OSFSessionattaches default headers includingContent-TypeandAcceptto every request. However, the WaterButler S3 provider does not include these headers when generating presigned URLs. When the rdmclient follows a redirect to a presigned URL while forwarding those extra headers, the signature no longer matches and S3 returns403 SignatureDoesNotMatch.Changed
When a streaming request is redirected to a presigned URL, this change forwards only the headers that are expected/covered by the presigning process, and avoids forwarding specific headers that invalidates the signature.
Scope
This affects only
GETrequests that follow redirects to presigned URLs returned by the corresponding WaterButler providers. Currently relevant providers include: