testsuite: rocm.exp: Limit wave output logged by info_threads_get_wave_count - #299
testsuite: rocm.exp: Limit wave output logged by info_threads_get_wave_count#299akondrat-amd wants to merge 1 commit into
Conversation
|
What problem exactly are we trying to solve? A timeout? A expect buffer overflow? |
We count waves at least three times in a couple of tests, it adds thousands of lines to the log, particularly, 3 x 16,384. It's a nightmare to scroll through it. |
|
Honestly I think we need a command to give us the number of waves we have. It is not feasible to count waves by going through a wall of text. For instance, if we run this with check-read1, it will be very slow. |
7fe6840 to
d6fee8a
Compare
…e_count On GPUs with many wavefronts, info_threads_get_wave_count floods the log with thousands of lines. Print only the first and last 20 wave lines, replacing the omitted middle with a single summary line "... N waves omitted ...".
d6fee8a to
3659584
Compare
Running with check-read1 takes ~30 seconds longer with 3,000 waves regardless of this fix. |
|
@amd-shahab Thoughts here? I do not think we should try to handle this in TCL. |

On GPUs with many wavefronts, info_threads_get_wave_count floods the log with thousands of lines. Print only the first and last 20 wave lines, replacing the omitted middle with a single summary line "... N waves omitted ...".
Key changes: