-
Notifications
You must be signed in to change notification settings - Fork 55
gfx1200 memory limits milestone3-babel (#1671) #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ronlieb
commented
Nov 22, 2025
swdev-565113 Please enter the commit message for your changes. Lines starting
carlobertolli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits can be fixed post merge
| save_status | ||
| ./milestone-3-babel -n 20 -s 100000000 # 2400.0 MB | ||
| save_status | ||
| if [[ "$AOMP_GPU" =~ ^gfx12.* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would limit it to gfx1200 and gfx1201
|
|
||
| $PRECMD ./milestone-3-babel -n 20 -s 100000000 # 2400.0 MB | ||
| save_status | ||
| if [[ "$AOMP_GPU" =~ ^gfx12.* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
gregrodgers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
re-running test seems infra issue - http://rocm-ci.amd.com/job/rocm-tests/34924/ |
|
Landing this as PSDB rocm-ci failures are unrelated, as this is a fortran update. Failures in rocgdb, ocl, rocprof are irrelevant |