Migrating to Golang based collectors instead of parallel-ssh and also…#219
Open
venksrin09 wants to merge 1 commit into
Open
Migrating to Golang based collectors instead of parallel-ssh and also…#219venksrin09 wants to merge 1 commit into
venksrin09 wants to merge 1 commit into
Conversation
… support for any user defined key file names, we had a bug and only accepting standard key file names like id_rsa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For larger number of nodes, parallel-ssh and asyncio are very slow and often take over 20 mins to fetch the commands and do not seem to work well for over 100 nodes. So based on Ignatious suggestions, I have migrated to Golang and was able to test with the 160 nodes in OSSCI. Also made one more bug fix.
Test Plan
Validated with the 165 nodes from OSSCI and all the initial counters show up in UI in less than a minute compared to 20 mins before.
Test Result
Validated all the tabs - metrics, logs
Submission Checklist