ci(hip-kernel-provider): enable rocKE C++ tests in TheRock CI#9134
Open
shumway wants to merge 1 commit into
Open
ci(hip-kernel-provider): enable rocKE C++ tests in TheRock CI#9134shumway wants to merge 1 commit into
shumway wants to merge 1 commit into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
ISSUE ID : AICK-1517 Turn on the rocKE build in CI so its host-only C++ smoke tests run in the hipkernelprovider lane: - therock_matrix.py: add -DTHEROCK_FLAG_HIPKERNELPROVIDER_ENABLE_ROCKE=ON to the hip-kernel-provider entry. The THEROCK_FLAG_ prefix forwards the define down into the hipkernelprovider subproject's CMake (a bare -DHIPKERNELPROVIDER_ENABLE_ROCKE would stay at the superbuild level and never reach the provider). - ci-env/action.yml: bump therock-ref to d34f879 (2026-07-06) so TheRock includes the flag propagation + test-artifact includes. Gate the two Python rocKE tests (import smoke + golden byte-stability) behind a new ROCKE_INSTALL_PYTHON_TESTS option and set it OFF in provider mode: their test-artifact packaging (the rocke package, the scripts, and the golden JSON) is not yet in TheRock's hipkernelprovider includes, so staging them there would fail at test time. Standalone builds keep them on. Only the C++ smoke tests (rocke_ir_serialize_roundtrip, rocke_tiled_attention_2d_reentrancy) run in CI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shumway
force-pushed
the
users/shumway/rocke-enable-ci
branch
from
2118715 to
1f6eadf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE ID : AICK-1517
Motivation
We are adding CI coverage to the rocKE code in hip kernel provider. This PR turns on some minimal rocKE tests. This overlaps with #9115, so we'll likely defer to that PR for the initial commit.
Technical Details
Turn on the rocKE build in CI so its host-only C++ smoke tests run in the hipkernelprovider lane:
Gate the two Python rocKE tests (import smoke + golden byte-stability) behind a new ROCKE_INSTALL_PYTHON_TESTS option and set it OFF in provider mode: their test-artifact packaging (the rocke package, the scripts, and the golden JSON) is not yet in TheRock's hipkernelprovider includes, so staging them there would fail at test time. Standalone builds keep them on. Only the C++ smoke tests (rocke_ir_serialize_roundtrip, rocke_tiled_attention_2d_reentrancy) run in CI.
Test Plan
This PR should cause the existing tests to be triggered.
Test Result
TBD
Submission Checklist