rocdbgapi: add a process id argument to convert_address_space - #10163
Open
aktemur wants to merge 4 commits into
Open
rocdbgapi: add a process id argument to convert_address_space#10163aktemur wants to merge 4 commits into
aktemur wants to merge 4 commits into
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
The name of an input parameter in the documentation of the `amd_dbgapi_convert_address_space` function is incorrect. Fix it.
Raise AMD_DBGAPI_STATUS_ERROR_INVALID_ARGUMENT_COMPATIBILITY in amd_dbgapi_address_dependency if the wave given as argument does not belong to the process. This is a sanity check.
If a wave is not given, try all agents of the process to lower the address. For each lowered address, require PROCESS dependency. This helps us check dependency of generic addresses to the global address space, which have to be lowered first before checking dependency. Otherwise such generic addresses incorrectly raise an error in address dependency.
Make amd_dbgapi_convert_address_space accept a process id as an argument. This is required to be able to convert generic addresses to global addresses, in which case a wave may not be available. To do the conversion, lower the address in every agent of the process. For each, we must get the same answer for the conversion to the global address space to be valid. Before this change, converting a generic address to global without a wave was giving an error. After this change, conversion takes place successfully. AIROCGDB-644
aktemur
force-pushed
the
users/aktemur/convert-address-process-id
branch
from
August 18, 2026 14:36
e25474f to
2af3fee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a process id argument to
convert_address_space, so that generic -> global conversions can be made when wave is not available.Technical Details
When a generic address points to the global address space, wave may not be available, since the address does not depend on a wave in that case. Accept a process id and use it. See the patches for more details.
Issue Tracking
JIRA ID: AIROCGDB-644
Test Plan
Tested by ROCgdb PR ROCm/ROCgdb#255.
Test Result
Pass.