Skip to content

refactor(rocdbgapi): set a workgroup's mark unconditionally - #9428

Closed
aktemur wants to merge 1 commit into
developfrom
users/aktemur/workgroup-set-mark
Closed

refactor(rocdbgapi): set a workgroup's mark unconditionally#9428
aktemur wants to merge 1 commit into
developfrom
users/aktemur/workgroup-set-mark

Conversation

@aktemur

@aktemur aktemur commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Motivation

This change is a refactoring to obtain clearer and simpler code.

Technical Details

A workgroup is alive as long as it has a wave. Set the epoch mark unconditionally, whenever the mark of any wave of the workgroup is being set.

Issue Tracking

None.

Test Plan

Tested by gdb.rocm tests in ROCgdb testsuite.

Test Result

A workgroup is alive as long as it has a wave.  Set the epoch mark
unconditionally, whenever the mark of any wave of the workgroup is
being set.

In practice, this should not change the epoch value of a workgroup.
This change is a refactoring to obtain clearer and simpler code.
@aktemur
aktemur requested a review from a team as a code owner July 29, 2026 08:09
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocdbgapi/src/queue.cpp; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@aktemur

aktemur commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

I cherry-picked this patch into #7992. Closing this PR.

@aktemur aktemur closed this Jul 31, 2026
@aktemur
aktemur deleted the users/aktemur/workgroup-set-mark branch August 13, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant