fix(rocdbgapi): exit early if accessing nullptr - #9707
Merged
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
Author
|
ROCgdb companion PR: ROCm/ROCgdb#250 |
lancesix
reviewed
Aug 5, 2026
aktemur
force-pushed
the
users/aktemur/nullptr-access
branch
from
August 5, 2026 15:04
83b4515 to
1d87585
Compare
aktemur
force-pushed
the
users/aktemur/nullptr-access
branch
3 times, most recently
from
August 6, 2026 09:07
2f88a32 to
edef625
Compare
lumachad
approved these changes
Aug 6, 2026
lumachad
left a comment
Contributor
There was a problem hiding this comment.
OK. Windows failures unrelated.
Contributor
Author
|
The ASAN failures are unrelated. |
When accessing the memory, check if accessing the nullptr and if so, exit early with an error. AIROCGDB-645
aktemur
force-pushed
the
users/aktemur/nullptr-access
branch
from
August 7, 2026 06:59
edef625 to
f572509
Compare
systems-assistant Bot
pushed a commit
to ROCm/ROCdbgapi
that referenced
this pull request
Aug 7, 2026
When accessing the memory, check if accessing the nullptr and if so, exit early with an error. AIROCGDB-645 [rocm-systems] ROCm/rocm-systems#9707 (commit d5bfa59)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Check for nullptr access and do not attempt to access memory. Give a proper error.
Technical Details
When accessing the memory, check if accessing the nullptr and if so, exit early with an error, so that we don't go into lower layers.
Issue Tracking
Bug: AIROCGDB-645
Test Plan
A new test to be included in ROCgdb.
Test Result
Passes with this patch, fails without.