Fix Suppress Tooltips behaviour - #6029
Open
bubblobill wants to merge 4 commits into
Open
Conversation
- Rearranged logic - Added return value for "lib:" uris. Reworded the appalling i18n text
Added extra check on "lib:" uris for presence of "macro"
| return MacroLinkFunction.getInstance().macroLinkToolTip(href); | ||
| } else if (href.toLowerCase().startsWith("lib:")) { | ||
| // just show the URL | ||
| return href; |
Collaborator
There was a problem hiding this comment.
If I'm understanding the feature correctly (that's a big if), the whole point is to avoid revealing the macro link URL. So if lib:/.../macro/... also counts as a macro link, we should also avoid showing that URL and instead show details similar to what is done for macro: URLs.
Collaborator
Author
There was a problem hiding this comment.
@kwvanderlinde You are correct.
The FR is to fix the tooltip suppression on non-macroLink URLs and to also catch lib:/.../macro/... links.
Sadly the function macroLinkToolTip will not work on the lib: URL, so I had to choose between showing the link or letting it fall through. I opted for returning the link as this prioritises accessibility over presentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #6028
Description of the Change
TooltipView:
i18n.properties
Possible Drawbacks
I unwrapped the double negatives poorly.
People using span tags for tooltips that also have a title attribute on their links will get weird results.
Documentation Notes
n/a
Release Notes
n/a
This change is