CI: Refactor of PR HTML generator workflow - #5050
Merged
Merged
Conversation
- Only push to Docker Hub if we can assume that credentials are available (no, you cannot access secrets.DOCKER_PASSWORD in the `if` there) - Push to the GHCR name of the current repo, fixing forks - Also push long SHA labels to easily use them in PR HTML Generator
This splits the workflow into two. The main functionality testing the PR is run as unprivileged pull_request workflow and uploads the results as artifacts. The privileged workflow_run workflow takes these, uploads them to GH Pages and writes/updates a comment. The latter does not interact with the PR content any further. Controversial change: Try to use the prebuilt base/current container instead of building it again inside of this action. With unfavorable timing, this can lead to spurious errors. This fixes RSS-Bridge#5048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5048 by splitting HTML generation and privileged upload/comment tasks.
Also contains fixes for forked repos so that the container build doesn't run into errors.
I tested this on my fork and it seems to work now.