CI: Avoid persisting git credentials - #5073
Merged
Merged
Conversation
Following zizmor recommendations. The prhtmlupload workflow needs the credentials to push git commits at the end.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens GitHub Actions workflows by preventing actions/checkout from persisting the repository token in the local git config, aligning with zizmor’s recommendation to reduce credential exposure risk during CI runs.
Changes:
- Configure
actions/checkout@v7withpersist-credentials: falsein the test workflow. - Configure
actions/checkout@v7withpersist-credentials: falsein the PR HTML generation workflow (both PR and base checkouts). - Configure
actions/checkout@v7withpersist-credentials: falseacross all jobs in the lint workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/tests.yml | Disables persisted git credentials for the test checkout step. |
| .github/workflows/prhtmlgenerator.yml | Disables persisted git credentials for both PR and base repository checkouts. |
| .github/workflows/lint.yml | Disables persisted git credentials for all lint job checkouts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following zizmor recommendations. The prhtmlupload workflow needs the credentials to push git commits at the end.