Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a configurable terminationGracePeriodSeconds parameter to the TON Rust Node Helm chart (v0.4.3). The Kubernetes default of 30 seconds is too short for a TON node, as an unclean kill may corrupt the database and force a cold boot. The new parameter defaults to 300 seconds (5 minutes), allowing graceful shutdown time for the node process.
Changes:
- Added
terminationGracePeriodSecondsparameter to values.yaml with a default value of 300 seconds - Integrated the parameter into the StatefulSet pod specification
- Updated Chart version from 0.4.2 to 0.4.3
- Added CHANGELOG entry documenting the new feature
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| helm/ton-rust-node/values.yaml | Added terminationGracePeriodSeconds parameter with comprehensive documentation explaining the rationale |
| helm/ton-rust-node/templates/statefulset.yaml | Configured the StatefulSet to use the new parameter at the pod spec level |
| helm/ton-rust-node/Chart.yaml | Bumped version to 0.4.3 |
| helm/ton-rust-node/CHANGELOG.md | Added release notes entry for version 0.4.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bvscd
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminationGracePeriodSeconds— configurable grace period before SIGKILL on pod termination. Defaults to 300s (5 minutes). The Kubernetes default of 30s is too short for a TON node — an unclean kill may corrupt the database and forces a cold boot