Skip to content

fix(btcli): trim wallet balance decimals - #3124

Open
UnArbosFive wants to merge 1 commit into
mainfrom
fix/wallet-balance-decimals
Open

fix(btcli): trim wallet balance decimals#3124
UnArbosFive wants to merge 1 commit into
mainfrom
fix/wallet-balance-decimals

Conversation

@UnArbosFive

Copy link
Copy Markdown
Contributor

Summary

  • Format human btcli wallet balance amounts to three decimal places.
  • Keep exact nine-decimal Balance formatting and JSON fields unchanged.
  • Apply the same concise formatting to single-wallet details and the aggregate total.

Verification

  • uv run --no-sync ruff check bittensor/cli/helpers.py bittensor/cli/commands/wallet.py tests/unit/test_cli.py
  • uv run --no-sync ruff format --check bittensor/cli/helpers.py bittensor/cli/commands/wallet.py tests/unit/test_cli.py
  • uv run --no-sync pytest tests/unit/test_cli.py -q (blocked: locked environment is missing qrcode)

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview Aug 28, 2026 1:42pm

Request Review

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

HIGH scrutiny by account age, tempered by admin permission and substantial merged history; no Gittensor association found. Branch: fix/wallet-balance-decimals → main.

The change is limited to human-readable Python CLI formatting. Exact Balance values and JSON fields remain unchanged, and no runtime, dependency, CI, or trust-boundary files are modified.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found in the static diff.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

UNKNOWN Gittensor association; high account-age scrutiny tempered by admin permission and substantial merged contribution history.

The implementation consistently limits human wallet-balance output to three decimals while preserving exact Balance values and JSON records. The overlapping PRs #3079 and #3101 address unrelated functionality, so neither is a duplicate.

git diff --check passed. Python Ruff checks were attempted but skipped because the existing environment lacks uv; no dependencies were installed. Targeted tests were not run because the formatting change did not require runtime confirmation.

Findings

No findings.

Conclusion

The change is focused, matches its description, and includes a direct formatting regression test. No domain correctness or repository-rule violations were found.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant