Fixes for aria-live regions #9524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toast messages are now announced. Messages with repeated content are announced for toasts and move related messages. Uses a small debounce to include move and toast messages when they occur together.
Collaborator
|
Presumably this needs rebasing on the latest changes to improve the state of the checks. I'm happy to do this, please let me know. |
Contributor
Author
|
I had just made this to experiment with, but I haven't been able to substantially improve upon what you already had. I'm going to close this for now; I think once things settle down we'll probably want to merge your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toast messages are now announced.
Messages with repeated content are announced for toasts and move related messages.
Uses a small debounce to include move and toast messages when they occur together.
The basics
The details
Resolves
Fixes
Proposed Changes
Reason for Changes
Test Coverage
Documentation
Additional Information