Repository navigation
fix!: 无法确认进程关键状态时拒绝结束操作 - #77
Merged
Merged
Conversation
Query criticality through the same validated process handle used for termination. Distinguish an unsuccessful safety check from a successful negative result and reject unknown criticality even when forced. BREAKING CHANGE: Privileged service protocol 12 is required for brokered process actions. Older services fall back to local permissions through the existing compatibility path.
hayxe1
marked this pull request as ready for review
November 12, 2026 09:21
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动内容 / Changes
原实现会把关键进程查询失败当作“非关键”,且查询另开 PID 句柄。现在使用
IsProcessCritical查询同一个已验证创建时间的句柄,所需权限为PROCESS_QUERY_LIMITED_INFORMATION;查询失败返回独立的criticalityUnknown,即使请求强制结束也不允许操作。单个进程、成组结束与进程树路径使用同一规则;进程树结果单独统计关键状态未知的失败。已确认的关键进程仍遵循原有显式确认流程。
A failed critical-process query no longer becomes a successful negative result. The safety check uses the same validated instance handle as termination. Unknown criticality blocks normal and forced termination, including grouped/tree paths, while known critical processes keep their existing explicit-confirmation behavior.
Compatibility / 兼容性
BREAKING CHANGE: Brokered process actions require privileged-service protocol 12. An older service follows the existing compatibility/local-permission fallback; update the service to restore compatible brokered actions. No installed service, driver, Task Manager replacement or product version was changed on the development PC.
验证 / Validation
argus-core,argus-service, native host; all targets, warnings denied), Rust formatting, generated dispatch and eight-locale validation passed.检查清单 / Checklist
start.bat check(targeted checks above; CI remains authoritative).