Repository navigation
feat!: 支持设置进程的 I/O 优先级与内存优先级 - #80
Conversation
BREAKING CHANGE: New daily history files use version 3 to retain process creation times. Version 2 files remain readable and continue in their original format for the current day. Older builds cannot read version 3 recordings. Back up history before downgrading.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0df39e5a7b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36de7d8d1f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
进程右键菜单在“设置优先级”之后新增“I/O 优先级”(非常低、低、正常)与“内存优先级”(非常低、低、中、低于正常、正常)两个子菜单,按应用分组时作用于组内全部进程,当前取值在各成员一致时打勾。高与关键两档 I/O 优先级由 Windows 保留,界面不提供,服务与核心也拒绝设置。 当前取值随采样用已缓存的查询句柄读取,两项合计每进程约 0.6 µs。设置前校验 PID 与启动时间;权限不足时交给特权服务执行,服务新增 IoPriority 与 MemoryPriority 两项操作,校验规则与结束、暂停相同。特权服务的授权说明同步列出这两项。 BREAKING CHANGE: 特权服务协议升级到第 12 版,旧服务需要在“设置 → 权限”中更新。 Refs Ray-lea#49
“选择列”新增“I/O 优先级”(磁盘与 I/O 分类)与“内存优先级”(内存分类)两列,默认隐藏,按级别而非名称排序;应用分组行仅在成员一致时显示。详情面板在“优先级”之后列出这两项。取值来自采样时已读取的数据,不增加查询。 Windows 保留的“高”“关键”两档 I/O 优先级只用于显示。
设置 I/O 或内存优先级失败时,原因改用这两项操作自己的说明(无权限、服务版本不兼容、无法更改、进程已退出),不再沿用结束进程的提示;整句由各语言的文案组成,标点随界面语言。 两列优先级与 CPU 数据一同采样,计数查询超时、沿用上次读数时同样提示“正在更新”;悬停提示显示本地化的级别名称,而非内部标识。
简体与繁体中文的 I/O 优先级、内存优先级无权限提示此前沿用暂停的说法(“无法暂停或恢复”),改为对应的优先级操作。架构文档与代码注释中未注明测量条件的单次读取耗时一并删除。
子进程的 I/O 与内存优先级继承自运行测试的进程,CI 运行器以低 I/O 优先级启动它,测试因此在初始断言处失败。现在只要求初始级别可读,各级别的设置与读回不变。
dea8748 to
39cbe7b
Compare
Keep the resolved recorded frame when history buckets change and show the CPU values from the bucket that owns the selected peak.
Preserve the initial sampling schedule and the current Russian history wording while updating observation to the latest upstream code.
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f550617fd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| IoPriority { | ||
| pid: u32, | ||
| create_time: i64, | ||
| priority: IoPriority, | ||
| }, |
There was a problem hiding this comment.
Bump the protocol version for the new service operations
If an unelevated host connects to a service built from the base revision, both new setters fail even for locally writable targets. The base already advertises protocol 12 (crates/argus-service/src/lib.rs:50), but cannot deserialize these variants, so it closes the pipe. The probe in pipe::request_with_timeout then receives a matching v12 Pong and preserves the broken-pipe error instead of returning INCOMPATIBLE; consequently, commands::privileged never takes its local fallback or reports ServiceOutdated. Assign this extension a new protocol version and cover a base-v12 service in the compatibility test, which currently assumes the old service is PROTOCOL - 1.
Useful? React with 👍 / 👎.
进程右键菜单新增 I/O 优先级(非常低、低、正常)与内存优先级(五档)子菜单,应用组作用于全部成员,各成员一致时勾选当前级别;进程表新增两个默认隐藏的可选列,按级别排序,详情面板在“优先级”之后同步显示。设置前校验进程身份,高与关键 I/O 优先级由 Windows 保留,不可设置;当前取值随采样以已缓存的查询句柄读取,不增加额外查询。
BREAKING CHANGE: 特权服务 IPC 协议从 11 升至 12,已有服务需要更新。
改动内容 / Changes
Adds I/O priority and memory priority, the next part of #49 after suspend/resume.
IoPriority/MemoryPriorityoperations with the same PID/start-time and self/client guards as terminate and suspend. Protocol 11 → 12. The consent text lists the new operations in all 8 locales.scripts/native-dispatch.mjsnow imports the two new argument types.CPU affinity / CPU sets are left for a separate PR.
Refs #49
检查清单 / Checklist
<type>(<scope>): <描述>)/ The title and commit messages follow Conventional Commitsstart.bat check通过 /start.bat checkpasses — run as its parts (local Node is older than the pinned engine): i18n,cargo fmt, clippy-D warningsand Biome pass; all tests pass except 3 argus-service install-lock tests (admin,cleanup,driver) that fail the same way on a clean main on this machinedocs/中对应的页面 / Behavior changes are reflected indocs/locales/的中文与英文目录 / New text is in both the Chinese and English catalogs underlocales/(all 8 locales)