fix: improvement the privacy message in all languages#532
Merged
Conversation
|
Review changes with Changed Files
|
Member
Author
|
Oh, how disappointing! SemantifDiff did not pick up on the fact that the massive line in French and Spanish has just a few small changes. |
Contributor
|
|
In the translation you gave me for the WW blurb you included "(en anglais)" but not in this one. Should it be here too? |
Member
Author
You know, it's not really necessary, and it takes more space for little value. |
- the fact that we have to pay for Playsible is not relevant, that's our problem - "which devices" feels creepy to me, like we're tracking indivual devices. I already worded it as types of devices in French and Spanish when I translated, and here I am backporting that fix to English too.
joanise
force-pushed
the
dev.ej/fix-privacy-wording
branch
from
1ab84e0 to
150f451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Feedback sought?
Do you like the new text?
To see the differences more clearly, use the SemanticDiff link, there are really just small changes which the github diff fails to highlight well.
Priority?
low
How to test?
look at the PR preview
Confidence?
high
Version change?
no