feat: add Tier 3 testing classification for extended validation - #123
Merged
rnetser merged 2 commits intoJul 1, 2026
Merged
Conversation
Add Tier 3 (Extended Validation) as a new testing tier for tests with higher execution cost — longer runtime, heavier resource usage, or complex setup — that typically run in dedicated test cycles rather than standard CI lanes. Updated files: AGENTS.md, docs/testing-tiers.md, docs/stp-guide.md, README.md, stps/stp-template/stp.md, stps/stp-template/child-stp.md Signed-off-by: rnetser <rnetser@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation and STP templates now treat Tier 3 as a valid test classification. The tier guide, review checklists, milestone requirements, template tier options, and one example scenario were updated to reflect the new tier. ChangesTier 3 Testing Classification Rollout
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/stp-guide.md`:
- Line 166: Update the final sign-off checklist item in the STP guide so it does
not imply Tier 3 is mandatory for every feature; qualify the entry around the
checklist text that mentions Tier 1 / Tier 2 / Tier 3 tests defined by adding
“as applicable” or making Tier 3 conditional, so only relevant validation tiers
are required.
In `@README.md`:
- Line 86: Rephrase the coverage guidance in the README so it no longer implies
every STP must include Tier 3; update the test-coverage wording to clearly
distinguish the required Tier 1 and Tier 2 coverage from the optional Tier 3
extended-validation coverage. Locate the bullet mentioning Tier 1, Tier 2, and
Tier 3 test coverage and make it conditional so feature plans without Tier 3 do
not read as incomplete.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: fa426615-dcaf-4c06-a6ac-60dff33f598e
📒 Files selected for processing (6)
AGENTS.mdREADME.mddocs/stp-guide.mddocs/testing-tiers.mdstps/stp-template/child-stp.mdstps/stp-template/stp.md
Tier 3 is optional extended validation, not mandatory for every STP. Updated sign-off checklist and process milestone to say 'where applicable'. Signed-off-by: rnetser <rnetser@redhat.com> Co-authored-by: PI (claude-opus-4-6) <noreply@pi.dev> Signed-off-by: rnetser <rnetser@redhat.com>
Contributor
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Tier 3 (Extended Validation) as a new testing tier for tests with higher execution cost — longer runtime, heavier resource usage, or complex setup — that typically run in dedicated test cycles rather than standard CI lanes.
Changes
Summary by CodeRabbit