feat(template): add Self-Validation Testing as 14th testing type

[rnetser]

Summary

Add Self-Validation Testing to the STP framework so authors consider whether new test scenarios should be included in the self-validation test package.

Changes

File	Change
stps/stp-template/stp.md	New checkbox under Functional group (after Regression) with HTML guidance
stps/stp-template/child-stp.md	Matching entry with description + "Covered by parent STP" option
AGENTS.md	Review checklist updated (13→14 types), new review guidance item
docs/stp-guide.md	Added to Types of Testing list

Context

We have a self-validation test package — a curated subset of tests that run as product health checks. When planning new tests in an STP, authors should consider whether any new scenarios belong in this package. This change adds that consideration as a standard testing type checkbox alongside the existing 13 types.

Review Findings Addressed

• Blank line spacing consistent with existing template patterns
• Self-Validation placed after Regression in all files (template ordering)
• Child STP includes description suffix for clarity
• AGENTS.md enumeration order matches template structure

Summary by CodeRabbit

• Documentation
  • Updated testing guidance to include a new Self-Validation Testing item.
  • Clarified the test checklist so incomplete review items are easier to identify.
  • Expanded the template to prompt for self-validation test coverage when new operational scenarios are added.

[openshift-virtualization-qe-bot-3]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message
• /security-override - Set security check runs to pass (maintainers only)
• /security-override cancel - Re-run security checks

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest all - Run all available tests

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3
• /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

• /rebase - Rebase this PR branch onto its base branch

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)

📊 Review Process

Approvers and Reviewers

Approvers:

• rnetser

Reviewers:

• rnetser

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)

Security Checks

• Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
• Committer Identity Check: Verifies last committer matches PR author
• Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[coderabbitai]

Warning

Review limit reached

@rnetser, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9213d377-60ee-4ccf-bdb3-6dd6c0244c6b

📥 Commits

Reviewing files that changed from the base of the PR and between 8a940f4 and 96aa601.

📒 Files selected for processing (4)

• AGENTS.md
• docs/stp-guide.md
• stps/stp-template/child-stp.md
• stps/stp-template/stp.md

📝 Walkthrough

Walkthrough

CRITICAL flag first: this change touches four documentation files, all mundane, all consistent — no logic, no code paths, nothing to break. Adds a "Self-Validation Testing" checklist item to AGENTS.md, stp-guide.md, child-stp.md, and stp.md, and expands checklist completeness guidance in AGENTS.md.

Changes

Self-Validation Testing documentation update

Layer / File(s)	Summary
Review checklist expansion AGENTS.md	Testing-type count raised from 13 to 14; checklist review guidance expanded with an unchecked-item completeness rule and a Self-Validation confirmation requirement for core operational scenarios.
Template checklist item additions docs/stp-guide.md, stps/stp-template/child-stp.md, stps/stp-template/stp.md	Each adds a "Self-Validation Testing" checklist item (with details placeholder and coverage attribution) to the Test Strategy / Types of Testing sections.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• RedHatQE/openshift-virtualization-tests-design-docs#69: Both PRs update STP test-strategy checklist expectations in AGENTS.md and related STP templates.
• RedHatQE/openshift-virtualization-tests-design-docs#84: Both PRs modify AGENTS.md's Test Strategy/review checklist completeness requirements.

Suggested labels: can-be-merged

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-virtualization-qe-bot-5]

Clean rebase detected — no code changes compared to previous head (64fc123).

[rnetser]

/approve
/lgtm