feat: Add vm templates STD

[RoniKishner]

What this PR does / why we need it:

Add STD for testing Kubevirt virtual machine templates.

Which issue(s) this PR fixes:

• Admission behavior: verifies that templates whose defaulted parameters always produce a valid VM definition are accepted, while templates that would always produce an invalid VM are rejected by the admission webhook.
• Capability feature gate: verifies that disabling the Template capability blocks new template and template-request creation while preserving existing objects, and that re-enabling it restores full template workflows.

Special notes for reviewer:

jira-ticket:

https://redhat.atlassian.net/browse/CNV-86112

Summary by CodeRabbit

• Tests
  • Added coverage for VirtualMachineTemplate admission, verifying acceptance when defaulted parameters resolve to valid VM definitions, and rejection when they resolve to invalid definitions.
  • Added coverage for Template capability gating, ensuring new template creation and template-based requests are blocked when disabled and restored when re-enabled.
  • Strengthened validation for VM creation from existing template-based requests across capability state changes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2036eea0-d12d-41d3-a663-db908cb231ac

📥 Commits

Reviewing files that changed from the base of the PR and between cf33928 and dfeb9a2.

📒 Files selected for processing (2)

• tests/infrastructure/vm_template/test_vm_template_admission.py
• tests/infrastructure/vm_template/test_vm_template_capability.py

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• RedHatQE/openshift-virtualization-tests-design-docs (manual)

---

📝 Walkthrough

Walkthrough

Two new pytest modules add docstring-only test stubs for VirtualMachineTemplate admission and capability-gate scenarios. Both disable collection with __test__ = False; one covers admission outcomes, and the other covers disabling and re-enabling the Template capability.

Changes

VM Template test stubs

Layer / File(s)	Summary
Admission behavior test stubs tests/infrastructure/vm_template/test_vm_template_admission.py	Adds TestVMTemplateAdmission with two Polarion-marked, docstring-only test functions describing accepted and rejected defaulted-parameter admission cases.
Template capability disable checks tests/infrastructure/vm_template/test_vm_template_capability.py	Adds module/class setup plus four docstring-only tests covering blocked creation and preserved existing template resources after capability disable.
Template capability reenable checks tests/infrastructure/vm_template/test_vm_template_capability.py	Adds two docstring-only tests covering successful template creation and VM creation from template after the capability is re-enabled.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: new-tests

Suggested reviewers: rnetser, rlobillo, hmeir, dshchedr

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is related to the change, but "STD" is ambiguous and does not clearly summarize the new VM template test coverage.	Rename it to a specific summary, such as adding KubeVirt VM template admission and capability coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description follows the required template and includes the PR purpose, issue summary, and Jira ticket.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stp Link Required	✅ Passed	Both new test modules include module-level STP links, which covers the added classes and test functions in each file.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-virtualization-qe-bot-3]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message
• /security-override - Set security check runs to pass (maintainers only)
• /security-override cancel - Re-run security checks

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3
• /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

• /rebase - Rebase this PR branch onto its base branch

Custom Commands

• /test-plan - Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
• /rerun-smoke - Adds `retest-smoke` label on the PR to trigger smoke tests exectuion

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• geetikakay
• mijankow
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)

Security Checks

• Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
• Committer Identity Check: Verifies last committer matches PR author
• Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[RoniKishner]

/verified

[openshift-virtualization-qe-bot-3]

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the full Test Execution Plan (smoke decision, gating decision, and specific affected tests).
Do NOT submit a blocking review event (REQUEST_CHANGES/APPROVE).
Post a single inline PR comment on Files Changed (non-blocking COMMENT flow).

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file

2. Identify affected code paths, functions, and classes

3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes

4. Trace test dependencies through imports, shared utilities, fixture inheritance, fixture teardown, and yield from cleanup in conftest

5. Detect new tests introduced in the PR

6. Utilities and libs impact (when utilities/ or libs/ changes):
   You MUST use shell scripts (rg, git diff) to trace the full impact.
   Follow these sub-steps in order:

   6a. Identify modified symbols: For each changed file under utilities/ or libs/,
   list every modified function or method.
   Example: git diff HEAD~1 --unified=0 -- utilities/hco.py | grep '^[+-]def '

   6b. Find direct callers: Search tests and conftest for each symbol from 6a.
   Example: rg -l 'get_hco_version' tests/

   6c. Trace fixture teardown and cleanup: Find fixtures that reach
   the modified symbol through yield from or context-manager wrappers.
   Example: rg -l 'yield from.*enable_common_boot|def.*enable_common_boot' tests/

   6d. Trace same-file callers: In each changed file, find other functions
   whose body calls a modified symbol (including code after yield
   in @contextmanager helpers).
   Example: rg 'get_hco_version|enable_common_boot' utilities/hco.py

   6e. Expand transitively: If function A calls modified B, then
   tests/fixtures that call A are affected — even when the test body
   never imports B directly.

   Do NOT limit impact to tests that import the modified symbol only.

7. Smoke test impact: Intersect the affected set from step 6 with smoke-marked tests.
   Run: rg -l '@pytest.mark.smoke' tests/
   VERIFY the above command returned actual file paths before concluding False.
   Set True if either condition is met:

   • a smoke-marked file appears in the affected set from 6b-6e, OR
   • any conftest.py in the smoke test's parent-directory hierarchy (up to repo root)
     imports or calls a modified utilities/libs symbol — including autouse fixtures
     that depend on modified functions. ALL tests in that directory and below are affected.
     Example check: for each smoke_file, scan dirname(smoke_file)/conftest.py,
     dirname(dirname(smoke_file))/conftest.py, etc. for modified symbol imports
     and autouse fixtures that depend on modified symbols.

8. Gating test impact: Intersect the affected set from step 6 with gating-marked tests.
   Run: rg -l '@pytest.mark.gating' tests/
   Set True if a gating-marked file also appears in the affected set from 6b-6e.
   Utilities/libs changes often affect gating tests without affecting smoke tests.
   Do NOT stop analysis after concluding Run smoke tests: False.

Output rules:
Do NOT include analysis step numbers (1-8) in your visible output.

Your deliverable:
Your inline informational comment will be based on the following requirements:

Test Execution Plan

• Run smoke tests: True / False — If True, state the dependency path (test → fixture → changed symbol). True ONLY with a verified path.
• Run gating tests: True / False — If True, state the dependency path. True if any gating-marked test is in the affected set.
• Affected tests to run (required when utilities/, libs/, or shared conftest changes — list concrete paths even when smoke is False)

Use these formats:

• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When a marker covers multiple affected tests (e.g. -m gating only if ALL gating tests in scope need run)
• Tag each listed test or group with its marker when not obvious, e.g. (gating) or (smoke)

Real test commands (MANDATORY when changes affect session/runtime code):

When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
config hooks, session-scoped setup) or modifies runtime behavior that unit tests mock away,
you MUST include concrete pytest commands the PR author must run on a real cluster
to verify the change works end-to-end. Include:

• A command for the error/fix path (the scenario the PR fixes)
• A command for the happy path (regression: the normal case still works)
• Use lightweight tests (e.g., --collect-only for startup failures,
  a single small test for runtime behavior)
  If the PR only changes test logic (not utilities/libs/conftest), the affected test
  paths themselves serve as the real test commands — no separate section needed.

Example output for a session-startup fix:

**Real tests (cluster required)**
Error path (the fix):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=nonexistent-sc --collect-only`
Expected: ValueError with clear message, not IndexError

Happy path (regression):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=<valid-sc> -k test_bar`
Expected: session starts normally

Guidelines:

• Include tests affected directly OR via fixture setup/teardown, yield from cleanup, or transitive utility call chains (caller calls modified helper)
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name when only specific tests use an affected fixture or utility wrapper (preferred for partial file impact)
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal
• Example: if leaf helper foo() changes, include tests whose fixture teardown calls wrapper bar() where bar() calls foo(), even when the test body only imports an unrelated symbol from the same utilities module

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

• Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
• Test Plan: MUST verify both WITH and WITHOUT hardware:
  • Run affected tests on cluster WITH hardware
  • Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

1. YOUR ONLY DELIVERABLE: Post one non-blocking inline comment containing the test execution plan on the first changed line
2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
3. FALLBACK ONLY: If inline comment API calls fail after retrying, post as a regular PR comment
4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

• ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
• ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
• ❌ Do NOT add any follow-up comments after submitting the review
• ❌ Do NOT reply to confirm task completion
• ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL — Verification rules for smoke and gating decisions:
- For each True decision, you must have traced a concrete path: test file → fixture → utility function → modified symbol.
- Do NOT assume impact based on scope, file proximity, or infrastructure-sounding names.
Only set True when you trace a concrete path through steps 6a-6e, then 7 or 8.
WRONG: "utilities/hco.py changed → run smoke" (no traced dependency path)
WRONG: "Run smoke tests: False" with no affected-test list when gating tests use the changed utility
RIGHT: "Run smoke tests: False, Run gating tests: True" plus tests/.../test_foo.py::TestBar::test_baz (gating)
RIGHT: "Smoke test X uses fixture Y → wrapper Z → changed function W in utilities/hco.py"

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
echo "--- Files changed in PR (approx) ---"
fd . tests/infrastructure/vm_template 2>/dev/null || true
echo "--- test_vm_template_admission.py ---"
cat -n tests/infrastructure/vm_template/test_vm_template_admission.py 2>/dev/null || echo "not found"
echo "--- test_vm_template_capability.py ---"
cat -n tests/infrastructure/vm_template/test_vm_template_capability.py 2>/dev/null || echo "not found"
echo "--- conftest hierarchy ---"
fd conftest.py tests/infrastructure 2>/dev/null
echo "--- markers in these files ---"
rg -n 'pytest.mark' tests/infrastructure/vm_template/ 2>/dev/null || true

Length of output: 2639

---

@openshift-virtualization-qe-bot-3

Test Execution Plan

• Run smoke tests: False — No utilities/ or libs/ files are modified in this PR; only two brand-new test files are added (tests/infrastructure/vm_template/test_vm_template_admission.py, tests/infrastructure/vm_template/test_vm_template_capability.py). No conftest.py or shared fixture changes exist in the diff, so there is no dependency path from any smoke-marked test to a changed symbol.
• Run gating tests: False — Same reasoning; no changed utility/lib symbol exists for a gating test to depend on transitively.
• Affected tests to run: None can be meaningfully executed yet.
  • Both new files set __test__ = False at module and class level (TestVMTemplateAdmission, TestVMTemplateCapability), and every test method (test_valid_template_with_defaulted_parameters_accepted, test_invalid_by_default_template_rejected, and the six Polarion-marked methods in TestVMTemplateCapability) currently contains only a descriptive docstring with no executable steps or assertions. Pytest will not collect these as real tests in this state, so there is nothing to run on a cluster yet.

Real tests (cluster required): Not applicable at this stage — there is no runtime/session code change and no executable test body to validate. Once the test bodies are implemented with actual admission/webhook and feature-gate assertions, a follow-up plan should cover:

• pytest tests/infrastructure/vm_template/test_vm_template_admission.py -k test_valid_template_with_defaulted_parameters_accepted
• pytest tests/infrastructure/vm_template/test_vm_template_admission.py -k test_invalid_by_default_template_rejected
• pytest tests/infrastructure/vm_template/test_vm_template_capability.py

Note: I don't have a capability to post inline PR review comments outside of the normal review flow; this plan is provided as a regular comment reply.

[geetikakay]

@RoniKishner maybe in the PR description add the STP link?

[rnetser]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 40bc1413-fa4e-4604-8eaa-8177e8ee0efa

📥 Commits
Reviewing files that changed from the base of the PR and between e287002 and cf33928.

📒 Files selected for processing (2)

• tests/infrastructure/vm_template/test_vm_template_admission.py
• tests/infrastructure/vm_template/test_vm_template_capability.py

📝 Walkthrough

Walkthrough

Two new pytest test modules are added under tests/infrastructure/vm_template/. Both define test classes with __test__ = False and contain only docstrings describing intended VirtualMachineTemplate admission and capability-gate behaviors, without executable test logic.

Changes

VM Template test stubs

Layer / File(s) Summary
Admission behavior test stubs
tests/infrastructure/vm_template/test_vm_template_admission.py Adds TestVMTemplateAdmission class with two Polarion-marked, docstring-only test functions describing expected accept/reject outcomes for defaulted VM template parameters.
Capability gate test stubs
tests/infrastructure/vm_template/test_vm_template_capability.py Adds TestVMTemplateCapability incremental test class with six Polarion-marked, docstring-only test functions describing expected blocking/preservation/reenabling behavior of VirtualMachineTemplate and VirtualMachineTemplateRequest creation when the Template capability is disabled/reenabled.
Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: new-tests

Sequence Diagram(s)

Not applicable — both modules contain only docstring placeholders without executable logic or observable component interactions.

Poem

A rabbit hopped through fields of test, Found stub files, docstrings dressed, No asserts, no calls to trace, Just Polarion tags in place, "Someday soon," it twitched with glee, "These stubs will run for you and me!" 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is under 120 characters and clearly indicates a change adding VM templates STD coverage.
Description check ✅ Passed The PR description matches the template sections and includes a Jira ticket, with only minor gaps in reviewer notes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stp Link Required ✅ Passed Both added test modules include module-level STP URLs, so the new test classes/functions are traceable as required.
✨ Finishing Touches
🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems
Linked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped RedHatQE/openshift-virtualization-tests-design-docs.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

you now have access to other repositories; do complete review

[coderabbitai]

@rnetser Re-running the full review now, including the newly accessible linked repository context. This matters because cross-repo references can affect completeness, especially when requirements, test intent, or shared design context live outside the main PR diff.

✅ Action performed

Full review finished.

[rnetser]

@rnetser Re-running the full review now, including the newly accessible linked repository context. This matters because cross-repo references can affect completeness, especially when requirements, test intent, or shared design context live outside the main PR diff.

✅ Action performed

@coderabbitai
you did not post review trail and decision

[coderabbitai]

@rnetser You're right — the previous run only posted the "Action performed" acknowledgment without a visible review trail (files analyzed, per-file findings, and final decision). That's not the expected behavior; a full review should always surface a summary comment with the outcome, even when it's "no actionable comments."

Re-triggering the full review now so the walkthrough/summary and decision get posted as a visible trail on the PR:

✅ Action performed

Full review finished.

---

Your plan includes PR reviews subject to rate limits. More reviews will be available in 42 minutes.

[RoniKishner]

/verified

[openshift-virtualization-qe-bot-3]

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the full Test Execution Plan (smoke decision, gating decision, and specific affected tests).
Do NOT submit a blocking review event (REQUEST_CHANGES/APPROVE).
Post a single inline PR comment on Files Changed (non-blocking COMMENT flow).

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file

2. Identify affected code paths, functions, and classes

3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes

4. Trace test dependencies through imports, shared utilities, fixture inheritance, fixture teardown, and yield from cleanup in conftest

5. Detect new tests introduced in the PR

6. Utilities and libs impact (when utilities/ or libs/ changes):
   You MUST use shell scripts (rg, git diff) to trace the full impact.
   Follow these sub-steps in order:

   6a. Identify modified symbols: For each changed file under utilities/ or libs/,
   list every modified function or method.
   Example: git diff HEAD~1 --unified=0 -- utilities/hco.py | grep '^[+-]def '

   6b. Find direct callers: Search tests and conftest for each symbol from 6a.
   Example: rg -l 'get_hco_version' tests/

   6c. Trace fixture teardown and cleanup: Find fixtures that reach
   the modified symbol through yield from or context-manager wrappers.
   Example: rg -l 'yield from.*enable_common_boot|def.*enable_common_boot' tests/

   6d. Trace same-file callers: In each changed file, find other functions
   whose body calls a modified symbol (including code after yield
   in @contextmanager helpers).
   Example: rg 'get_hco_version|enable_common_boot' utilities/hco.py

   6e. Expand transitively: If function A calls modified B, then
   tests/fixtures that call A are affected — even when the test body
   never imports B directly.

   Do NOT limit impact to tests that import the modified symbol only.

7. Smoke test impact: Intersect the affected set from step 6 with smoke-marked tests.
   Run: rg -l '@pytest.mark.smoke' tests/
   VERIFY the above command returned actual file paths before concluding False.
   Set True if either condition is met:

   • a smoke-marked file appears in the affected set from 6b-6e, OR
   • any conftest.py in the smoke test's parent-directory hierarchy (up to repo root)
     imports or calls a modified utilities/libs symbol — including autouse fixtures
     that depend on modified functions. ALL tests in that directory and below are affected.
     Example check: for each smoke_file, scan dirname(smoke_file)/conftest.py,
     dirname(dirname(smoke_file))/conftest.py, etc. for modified symbol imports
     and autouse fixtures that depend on modified symbols.

8. Gating test impact: Intersect the affected set from step 6 with gating-marked tests.
   Run: rg -l '@pytest.mark.gating' tests/
   Set True if a gating-marked file also appears in the affected set from 6b-6e.
   Utilities/libs changes often affect gating tests without affecting smoke tests.
   Do NOT stop analysis after concluding Run smoke tests: False.

Output rules:
Do NOT include analysis step numbers (1-8) in your visible output.

Your deliverable:
Your inline informational comment will be based on the following requirements:

Test Execution Plan

• Run smoke tests: True / False — If True, state the dependency path (test → fixture → changed symbol). True ONLY with a verified path.
• Run gating tests: True / False — If True, state the dependency path. True if any gating-marked test is in the affected set.
• Affected tests to run (required when utilities/, libs/, or shared conftest changes — list concrete paths even when smoke is False)

Use these formats:

• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When a marker covers multiple affected tests (e.g. -m gating only if ALL gating tests in scope need run)
• Tag each listed test or group with its marker when not obvious, e.g. (gating) or (smoke)

Real test commands (MANDATORY when changes affect session/runtime code):

When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
config hooks, session-scoped setup) or modifies runtime behavior that unit tests mock away,
you MUST include concrete pytest commands the PR author must run on a real cluster
to verify the change works end-to-end. Include:

• A command for the error/fix path (the scenario the PR fixes)
• A command for the happy path (regression: the normal case still works)
• Use lightweight tests (e.g., --collect-only for startup failures,
  a single small test for runtime behavior)
  If the PR only changes test logic (not utilities/libs/conftest), the affected test
  paths themselves serve as the real test commands — no separate section needed.

Example output for a session-startup fix:

**Real tests (cluster required)**
Error path (the fix):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=nonexistent-sc --collect-only`
Expected: ValueError with clear message, not IndexError

Happy path (regression):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=<valid-sc> -k test_bar`
Expected: session starts normally

Guidelines:

• Include tests affected directly OR via fixture setup/teardown, yield from cleanup, or transitive utility call chains (caller calls modified helper)
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name when only specific tests use an affected fixture or utility wrapper (preferred for partial file impact)
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal
• Example: if leaf helper foo() changes, include tests whose fixture teardown calls wrapper bar() where bar() calls foo(), even when the test body only imports an unrelated symbol from the same utilities module

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

• Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
• Test Plan: MUST verify both WITH and WITHOUT hardware:
  • Run affected tests on cluster WITH hardware
  • Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

1. YOUR ONLY DELIVERABLE: Post one non-blocking inline comment containing the test execution plan on the first changed line
2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
3. FALLBACK ONLY: If inline comment API calls fail after retrying, post as a regular PR comment
4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

• ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
• ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
• ❌ Do NOT add any follow-up comments after submitting the review
• ❌ Do NOT reply to confirm task completion
• ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL — Verification rules for smoke and gating decisions:
- For each True decision, you must have traced a concrete path: test file → fixture → utility function → modified symbol.
- Do NOT assume impact based on scope, file proximity, or infrastructure-sounding names.
Only set True when you trace a concrete path through steps 6a-6e, then 7 or 8.
WRONG: "utilities/hco.py changed → run smoke" (no traced dependency path)
WRONG: "Run smoke tests: False" with no affected-test list when gating tests use the changed utility
RIGHT: "Run smoke tests: False, Run gating tests: True" plus tests/.../test_foo.py::TestBar::test_baz (gating)
RIGHT: "Smoke test X uses fixture Y → wrapper Z → changed function W in utilities/hco.py"

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@openshift-virtualization-qe-bot-3

Test Execution Plan

• Run smoke tests: False — No utilities/ or libs/ files are changed in this PR; only two new test modules are added (tests/infrastructure/vm_template/test_vm_template_admission.py, tests/infrastructure/vm_template/test_vm_template_capability.py). No conftest.py or shared fixture is touched, so there's no dependency path from any smoke-marked test to a changed symbol.
• Run gating tests: False — Same reasoning; no changed utility/lib symbol exists that a gating test could depend on transitively.
• Affected tests to run: None executable yet.
  • Both files set __test__ = False at module and class level (TestVMTemplateAdmission, TestVMTemplateCapability). Every method — test_valid_template_with_defaulted_parameters_accepted, test_invalid_by_default_template_rejected, and the six Polarion-tagged methods in TestVMTemplateCapability — contains only a docstring, no assertions or steps. Pytest will not collect these as executable tests in this state.

Real tests (cluster required): Not applicable — no session/runtime code changed and no executable test body exists yet. Once bodies are implemented, a follow-up plan should cover:

• pytest tests/infrastructure/vm_template/test_vm_template_admission.py -k test_valid_template_with_defaulted_parameters_accepted
• pytest tests/infrastructure/vm_template/test_vm_template_admission.py -k test_invalid_by_default_template_rejected
• pytest tests/infrastructure/vm_template/test_vm_template_capability.py

Note (repeating from my prior reply on this PR): I don't have a capability to post inline review comments outside the standard review flow — this plan is provided as a regular comment reply, same as before. The underlying repository state hasn't changed since that analysis, so the conclusion is unchanged.

[mijankow]

/lgtm