Update websocket_client dependency version#526
Merged
JacobCallahan merged 1 commit intomasterfrom Feb 10, 2026
Merged
Conversation
JacobCallahan
force-pushed
the
JacobCallahan-depadjust
branch
3 times, most recently
from
effdcc7 to
69ab2e2
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates dependencies and provider integrations, including Azure subscription management imports and OpenShift client handling, likely to accommodate newer upstream library changes.
Changes:
- Switch Azure
SubscriptionClient/SubscriptionStateimports toazure-mgmt-subscriptionand add the corresponding dependency. - Relax the
openshiftdependency constraint and add a guarded import + explicit failure in the OpenShift connection path when the legacy static client API is unavailable.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
wrapanapi/systems/msazure.py |
Updates Azure subscription-related imports to use the newer subscription management package. |
wrapanapi/systems/container/rhopenshift.py |
Adds guarded import for legacy openshift.client and raises a clearer error when it’s not available. |
pyproject.toml |
Adds azure-mgmt-subscription dependency and changes openshift version constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tpapaioa
approved these changes
Feb 10, 2026
tpapaioa
left a comment
tpapaioa
left a comment
There was a problem hiding this comment.
LGTM, other than the 2 suggestions from Copilot.
ogajduse
approved these changes
Feb 10, 2026
Configuration: - Implement a try-except block for importing the `openshift.client` module to gracefully handle its removal in `openshift` versions >= 0.13. - Introduce a `_OPENSHIFT_CLIENT_AVAILABLE` flag to track the success of the `openshift.client` import. - Enhance the `_connect` method to raise an `ImportError` with a detailed message if the `openshift.client` module is not available. This guides users on required `openshift` library versions or migration to the dynamic client API, ensuring better compatibility with varying library versions. Refactoring: - Reordered import statements in `msazure.py` for `StorageManagementClient` for consistency.
JacobCallahan
force-pushed
the
JacobCallahan-depadjust
branch
from
69ab2e2 to
cef774a
Compare
Contributor
Author
|
Updated the message based on copilot's recommendation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempt to pin the websocket dependency to a higher version