Skip to content

refactor: remove maker-order subsystem - #16

Merged
tvolk131 merged 1 commit into
masterfrom
codex/remove-maker-orders
Jul 31, 2026
Merged

refactor: remove maker-order subsystem#16
tvolk131 merged 1 commit into
masterfrom
codex/remove-maker-orders

Conversation

@tvolk131

@tvolk131 tvolk131 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove MakerOrderV1 and the unused LMSR reservation from Simplicity, contracts/types, client builders and validation, node discovery/registration/interpretation/storage, RPC, CLI, fixtures, and CI gates
  • retain the generic market-only atomic package, indexing, replay, rollback, rebuild, and multi-market assurance introduced by test: add market-only orchestration assurance #15
  • simplify package, recovery, event, and store surfaces to the only supported family, including removal of the redundant MarketTree filter and affected_market_ids
  • reject retired maker RPC/capability/recovery/filter/event shapes explicitly, and require exact postcard record consumption so old alpha rows fail closed instead of decoding as the shorter market-only shape
  • align active docs with ADR 0006 and the RFQ-first roadmap while preserving maker audit and acceptance records at immutable pre-removal source links

Compatibility

This is an intentional clean alpha break. No maker contract has reached Liquid testnet, Liquid mainnet, or production, so there is no migration, compatibility mode, or recovery path. Existing local alpha databases should be deleted or rebuilt.

Per ADR 0006, the ALPN, RPC schema, package format, redb schema, and record version numbers remain unchanged. Old maker-era wire values and persisted rows are unsupported and fail closed.

Integration

This branch is rebased directly onto master after #12 and #15 merged. The conflict resolution preserves ADR 0006 and the liquidity roadmap, records Phase 0 as complete, retains ADR 0002 as the historical two-contract decision, and updates current documentation to the implemented market-only state.

Every non-document blob is byte-for-byte identical to the previously reviewed #16 tip, so the rebase did not change or lose any contract, code, test, fixture, manifest, lockfile, or justfile behavior.

Validation

  • post-rebase nix develop .#default --command just ci-checks — passed: format, warning-free Clippy, 183 tests passed / 4 live tests skipped, doc tests, and WASM check
  • nix develop .#default --command just regtest — previously passed all four retained live Elements gates; the rebased non-document tree is byte-identical
    • binary-market A/B lifecycle
    • atomic two-market transaction/index/reorg/rebuild
    • Elements RPC / Esplora backend equivalence
    • daemon / Iroh / CLI restart and rebuild boundary
  • independent conflict-resolution and tree-equivalence reviews — passed with no remaining actionable findings
  • git diff --check — clean

Base automatically changed from codex/market-only-assurance to master July 30, 2026 19:21
@tvolk131
tvolk131 force-pushed the codex/remove-maker-orders branch from df5bfda to bae7f46 Compare July 30, 2026 19:32
@tvolk131
tvolk131 merged commit 8c6273a into master Jul 31, 2026
2 checks passed
@tvolk131
tvolk131 deleted the codex/remove-maker-orders branch July 31, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant