refactor: remove maker-order subsystem - #16
Merged
Conversation
tvolk131
force-pushed
the
codex/remove-maker-orders
branch
from
July 30, 2026 19:32
df5bfda to
bae7f46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MakerOrderV1and the unused LMSR reservation from Simplicity, contracts/types, client builders and validation, node discovery/registration/interpretation/storage, RPC, CLI, fixtures, and CI gatesMarketTreefilter andaffected_market_idsCompatibility
This is an intentional clean alpha break. No maker contract has reached Liquid testnet, Liquid mainnet, or production, so there is no migration, compatibility mode, or recovery path. Existing local alpha databases should be deleted or rebuilt.
Per ADR 0006, the ALPN, RPC schema, package format, redb schema, and record version numbers remain unchanged. Old maker-era wire values and persisted rows are unsupported and fail closed.
Integration
This branch is rebased directly onto
masterafter #12 and #15 merged. The conflict resolution preserves ADR 0006 and the liquidity roadmap, records Phase 0 as complete, retains ADR 0002 as the historical two-contract decision, and updates current documentation to the implemented market-only state.Every non-document blob is byte-for-byte identical to the previously reviewed #16 tip, so the rebase did not change or lose any contract, code, test, fixture, manifest, lockfile, or
justfilebehavior.Validation
nix develop .#default --command just ci-checks— passed: format, warning-free Clippy, 183 tests passed / 4 live tests skipped, doc tests, and WASM checknix develop .#default --command just regtest— previously passed all four retained live Elements gates; the rebased non-document tree is byte-identicalgit diff --check— clean