refactor: type binary market covenant actions - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SLOTplus a typed five-operationACTIONsumEitherencoding behind checked Rust domain APIsWhy
Market v1 is still undeployed, so this takes the prelaunch breaking change now. The old witness exposed redundant, independently selectable fields (
PATH, amounts, redemption side, dummy oracle data) and duplicated path inference across the covenant, builder, and interpreter. The typed semantic action removes those degrees of freedom and makes invalid role/action combinations unrepresentable off chain.Consensus impact
This intentionally changes the binary-market CMR and all eight scriptPubKeys. The storage version (
0x01), eight slot tags, fixed YES coordinator, A/B RT schedule, and SimplicityHL 0.6 toolchain remain unchanged.Canonical golden CMR:
e8912f8e5deb3c04ba47eaacacc8d194ae0473e35cee9e171b8a71e3513abca0Verification
nix develop .#default --command just ci-checksnix develop .#default --command just regtest-market-abNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.