Skip to content

refactor: type binary market covenant actions - #21

Merged
tvolk131 merged 1 commit into
masterfrom
agent/binary-market-action-abi
Aug 1, 2026
Merged

refactor: type binary market covenant actions#21
tvolk131 merged 1 commit into
masterfrom
agent/binary-market-action-abi

Conversation

@tvolk131

@tvolk131 tvolk131 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the loose binary-market witness fields with authenticated SLOT plus a typed five-operation ACTION sum
  • derive path refinements, cancellation/redemption shape, burn quantity, and expiry token side from the slot and mandatory transaction outputs
  • centralize coordinator roles, exact input roles, layouts, and raw nested-Either encoding behind checked Rust domain APIs
  • decode the five exact branch-pruned finalized ACTION types instead of scanning anonymous widths or searching candidate interpretations
  • refresh the source ABI, both parameterized CMRs, all eight Taproot vectors, protocol docs, conformance evidence, and resource ceilings

Why

Market v1 is still undeployed, so this takes the prelaunch breaking change now. The old witness exposed redundant, independently selectable fields (PATH, amounts, redemption side, dummy oracle data) and duplicated path inference across the covenant, builder, and interpreter. The typed semantic action removes those degrees of freedom and makes invalid role/action combinations unrepresentable off chain.

Consensus impact

This intentionally changes the binary-market CMR and all eight scriptPubKeys. The storage version (0x01), eight slot tags, fixed YES coordinator, A/B RT schedule, and SimplicityHL 0.6 toolchain remain unchanged.

Canonical golden CMR:

e8912f8e5deb3c04ba47eaacacc8d194ae0473e35cee9e171b8a71e3513abca0

Verification

  • nix develop .#default --command just ci-checks
    • formatting and strict Clippy
    • 211 workspace tests
    • doc tests and WASM check
  • nix develop .#default --command just regtest-market-ab
    • 16 transactions confirmed across three production-shaped lifecycle chains
    • malformed proofs and follower-stack coordinator transplant rejected
  • all-path/both-RT-side budget corpus and exact decoder conformance tests
  • independent consensus review: no outstanding findings

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@tvolk131
tvolk131 marked this pull request as ready for review August 1, 2026 01:59
@tvolk131
tvolk131 merged commit d50df6f into master Aug 1, 2026
2 checks passed
@tvolk131
tvolk131 deleted the agent/binary-market-action-abi branch August 1, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant