refactor: split binary market Simf into modules - #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binary_market.simffocused on the witness ABI and covenant entrypointbinary_market/common.simfbinary_market/rt.simfbinary_market/transitions.simfbinary_market.simfas the soleSimplex.tomlbuild entry; smplx resolves and flattens its local imports into the embedded generated sourceWhy
The pre-launch binary market covenant had grown to 805 lines in one source file. This gives the contract an acyclic, reviewable module structure while keeping private helpers private wherever they do not cross a file boundary.
This is intentionally a mechanical refactor. No witness ABI, contract parameters, transition behavior, or consensus output is changed.
Consensus invariants
702f5d04f15bcdec3fa1070540bf2f68c0ecdcf40bc8aa8024e1e77ef19cd5ee090548f91e2f07d2e691216336b578bf15fcdbde96f2e4255e4e70c60e4c1931master; only imports and required cross-modulepubmodifiers were addedVerification
All commands ran inside
nix develop .#default:simplex buildcargo test --locked -p deadcat-contracts --test golden_vectorsjust ci(211 workspace tests, doc tests, wasm check, and live Elements lifecycle/indexing/process-boundary regtests)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.