PRs trigger draft releases - #45
Conversation
WalkthroughA new GitHub Actions workflow has been introduced to automate the process of creating and publishing a release. This workflow includes steps for setting up Node.js, extracting the application version, building a Tauri application, and finally, publishing the release. This streamlines the release process, ensuring consistency and efficiency. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/pr-draft-release.yml (1 hunks)
Additional comments: 3
.github/workflows/pr-draft-release.yml (3)
- 19-20: Verify that the file path
./src-tauri/tauri.conf.jsonand the propertypackage.versionexist and are correct in the project structure.
The verification of the file path
./src-tauri/tauri.conf.jsonand the propertypackage.versionhas been successful. The file exists in the project structure and contains the specified property with a valid version number.
53-57: The job
build-tauriinstalls dependencies only for Ubuntu. Ensure that platform-specific dependencies for macOS and Windows are also handled correctly.60-61: The Tauri action is used with a version tag of
v0. Verify that this tag points to a stable and appropriate version for the project's needs.
| @@ -0,0 +1,85 @@ | |||
| name: "publish" | |||
There was a problem hiding this comment.
The workflow is named "publish," which could be misleading as it's intended for creating draft releases. Consider renaming it to something more descriptive, like "create-draft-release".
| @@ -0,0 +1,85 @@ | |||
| name: "publish" | |||
|
|
|||
| on: pull_request | |||
There was a problem hiding this comment.
The workflow is triggered on every pull request. Consider adding conditions to trigger this workflow only for specific branches or under certain conditions to avoid unnecessary runs.
| - name: Publish release | ||
| id: publish-release | ||
| uses: actions/github-script@v6 | ||
| env: | ||
| release_id: ${{ needs.create-release.outputs.release_id }} | ||
| with: | ||
| script: | | ||
| github.rest.repos.updateRelease({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| release_id: process.env.release_id, | ||
| draft: false, | ||
| prerelease: false |
There was a problem hiding this comment.
The publish-release job marks the release as no longer a draft without any checks. Consider adding steps to ensure that the build was successful and the release is ready to be published.
1 participant
Summary by CodeRabbit
New Features
Chores