add mutex for switching pointer inspector address#1298
Merged
Jamiras merged 1 commit intoRetroAchievements:masterfrom Mar 21, 2026
Merged
add mutex for switching pointer inspector address#1298Jamiras merged 1 commit intoRetroAchievements:masterfrom
Jamiras merged 1 commit intoRetroAchievements:masterfrom
Conversation
Jamiras
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/310192285306454017/1149693430306447380/1478492057495539725
Because dolphin does memory reads in the non-UI thread, there's a race condition when changing the selected address in the pointer finder. Each time the selection changes, a message is queued to update the field list. If another message is queued before the first is processed, the code may try to modify the list using data from the previous node. If the nodes aren't the same size, an array indexing error can occur, leading to an exception or crash.
This PR adds a mutex and some redundancy logic to ensure only one address is processed at a time.