Skip to content

Add reusable workflow for checking build output#1

Open
snoack wants to merge 1 commit into
masterfrom
action-build-check
Open

Add reusable workflow for checking build output#1
snoack wants to merge 1 commit into
masterfrom
action-build-check

Conversation

@snoack
Copy link
Copy Markdown

@snoack snoack commented May 15, 2026

This extracts the shared build action used by work-diary and update-changelog-action into a reusable workflow.


This change is Reviewable

This extracts the shared build action used by work-diary and
update-changelog-action into a reusable workflow.
@snoack snoack requested a review from pkaminski May 15, 2026 21:16
Copy link
Copy Markdown
Member

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on snoack).


.github/workflows/check-build-output.yaml line 18 at r1 (raw file):

        with:
          node-version: "24"
          cache: yarn

At least Codex was convinced that actions/setup-node was incapable of caching Yarn 4 correctly, and explicit use of actions/cache was required. Are you sure this works? If so, should backport to a bunch of other workflows.

@snoack snoack requested a review from pkaminski May 15, 2026 23:23
Copy link
Copy Markdown
Author

@snoack snoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snoack made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pkaminski).


.github/workflows/check-build-output.yaml line 18 at r1 (raw file):

Previously, pkaminski (Piotr Kaminski) wrote…

At least Codex was convinced that actions/setup-node was incapable of caching Yarn 4 correctly, and explicit use of actions/cache was required. Are you sure this works? If so, should backport to a bunch of other workflows.

Well, Codex came up with this simplification, and asking it about it again now, it insists that this works with Yarn 4 since actions/setup-node internally uses actions/cache. I did no test it. I suppose once this has been merged we can rerun the CI for the integration changes in work-diary and update-changelog-action and see if it works.

Copy link
Copy Markdown
Member

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on snoack).


.github/workflows/check-build-output.yaml line 18 at r1 (raw file):

Previously, snoack (Sebastian Noack) wrote…

Well, Codex came up with this simplification, and asking it about it again now, it insists that this works with Yarn 4 since actions/setup-node internally uses actions/cache. I did no test it. I suppose once this has been merged we can rerun the CI for the integration changes in work-diary and update-changelog-action and see if it works.

How would we know it's working, though?

The Yarn maintainers seem to think (or did, 5 years ago) that caching node_modules and .yarn/install-state.gz would often be beneficial for our configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants