Tag published version and run check-types if declared.#2
Conversation
This will also require switching to write permissions in all callers; I'll commit those changes directly.
snoack
left a comment
There was a problem hiding this comment.
@snoack reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pkaminski).
.github/workflows/publish.yaml line 184 at r1 (raw file):
const name = pkg.name; const version = pkg.version; fs.appendFileSync(process.env.GITHUB_OUTPUT, `package_name=${name}\n`);
Does the package name even matter? In practice it's just the name of the repo, and therefore redundant in the commit message, or am I missing something?
pkaminski
left a comment
There was a problem hiding this comment.
@pkaminski made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on snoack).
.github/workflows/publish.yaml line 184 at r1 (raw file):
Previously, snoack (Sebastian Noack) wrote…
Does the package name even matter? In practice it's just the name of the repo, and therefore redundant in the commit message, or am I missing something?
Doesn't terribly matter, but Codex decided to give the tags' messages the full name@version treatment (see next to last line), and given that it's just a couple extra lines here I find it hard to get upset about it.
This will also require switching to write permissions in all callers; I'll commit those changes directly.
This change is